From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v4 06/14] eal: pci: vfio: add rd/wr func for
	pci bar space
Date: Fri, 15 Jan 2016 13:48:53 +0800
Message-ID: <20160115054853.GQ19531@yliu-dev.sh.intel.com>
References: <1452778117-30178-1-git-send-email-sshukla@mvista.com>
 <1452778117-30178-7-git-send-email-sshukla@mvista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Santosh Shukla <sshukla@mvista.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id EF9398E6A
 for <dev@dpdk.org>; Fri, 15 Jan 2016 06:47:27 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1452778117-30178-7-git-send-email-sshukla@mvista.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 14, 2016 at 06:58:29PM +0530, Santosh Shukla wrote:
...
> +int rte_eal_pci_read_bar(const struct rte_pci_device *device,
> +			 void *buf, size_t len, off_t offset,
> +			 int bar_idx)
> +
> +{
> +#ifdef VFIO_PRESENT
> +	const struct rte_intr_handle *intr_handle = &device->intr_handle;
> +	return pci_vfio_read_bar(intr_handle, buf, len, offset, bar_idx);
> +#else
> +	/* UIO's not applicable */
> +	RTE_SET_USED(device);
> +	RTE_SET_USED(buf);
> +	RTE_SET_USED(len);
> +	RTE_SET_USED(offset);
> +	RTE_SET_USED(bar_idx);
> +	return 0;
> +#endif

Maybe you could do that like what pci_map_device() does:

	switch(dev->kdrv) {
	case RTE_KDRV_NIC_VFIO:
		return pci_vfio_read_bar(..);
		break;
	default:
		RTE_LOG(.... not supported by driver: %d\n"..);
		break;
	}

With that, you could get rid of those ugly RTE_SET_USED....

	--yliu