From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Sender: Daniel Vetter Date: Fri, 15 Jan 2016 11:17:30 +0100 From: Daniel Vetter To: Laurent Pinchart Cc: Maxime Ripard , Mike Turquette , Stephen Boyd , David Airlie , Thierry Reding , Philipp Zabel , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, Chen-Yu Tsai , Hans de Goede , Alexander Kaplan , Boris Brezillon , Wynter Woods , Thomas Petazzoni , Rob Clark , Daniel Vetter Subject: Re: [PATCH v2 13/26] drm/fb_cma_helper: Remove implicit call to disable_unused_functions Message-ID: <20160115101730.GH19130@phenom.ffwll.local> References: <1452785109-6172-1-git-send-email-maxime.ripard@free-electrons.com> <1452785109-6172-14-git-send-email-maxime.ripard@free-electrons.com> <2014724.QmjXVju9UW@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <2014724.QmjXVju9UW@avalon> List-ID: On Fri, Jan 15, 2016 at 01:13:05AM +0200, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Thursday 14 January 2016 16:24:56 Maxime Ripard wrote: > > The drm_fbdev_cma_init function always calls the > > drm_helper_disable_unused_functions. Since it's part of the usual probe > > process, all the drivers using that helper will end up having their encoder > > and CRTC disable functions called at probe if their device has not been > > reported as enabled. > > > > This could be fixed by reading out from the registers the current state of > > the device if it is enabled, but even that will not handle the case where > > the device is actually disabled. > > > > Moreover, the drivers using the atomic modesetting expect that their enable > > and disable callback to be called when the device is already enabled or > > disabled (respectively). > > > > We can however fix this issue by moving the call to > > drm_helper_disable_unused_functions out of drm_fbdev_cma_init and make the > > drivers needing it (all the drivers calling drm_fbdev_cma_init and not > > using the atomic modesetting) explicitly call it. > > I'd rather add it to all drivers that call drm_fbdev_cma_init(). All the > atomic ones must have special code to cope with it that could be rendered > useless by the removal of the drm_helper_disable_unused_functions() call. That > code should be removed too, and it would be easier to check drivers one by one > and fixing them individually (outside of this patch series, unless you insist > ;-)) when removing the explicit drm_helper_disable_unused_functions() call. I had the same thought, but figured there's really no good reason ever to do this. I suspect most of that disable_unused_function stuff we have all over is supreme cargo-cult anyway ;-) > Other than that the patch looks fine to me. So went ahead and applied to drm-misc. -Daniel > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/drm_fb_cma_helper.c | 3 --- > > drivers/gpu/drm/imx/imx-drm-core.c | 1 + > > drivers/gpu/drm/sti/sti_drv.c | 1 + > > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 1 + > > 4 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c > > b/drivers/gpu/drm/drm_fb_cma_helper.c index c19a62561183..daa98d881142 > > 100644 > > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > > @@ -348,9 +348,6 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct > > drm_device *dev, > > > > } > > > > - /* disable all the possible outputs/crtcs before entering KMS mode */ > > - drm_helper_disable_unused_functions(dev); > > - > > ret = drm_fb_helper_initial_config(helper, preferred_bpp); > > if (ret < 0) { > > dev_err(dev->dev, "Failed to set initial hw configuration.\n"); > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c > > b/drivers/gpu/drm/imx/imx-drm-core.c index 7b990b4e96d2..e1db57791fc9 > > 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -312,6 +312,7 @@ static int imx_drm_driver_load(struct drm_device *drm, > > unsigned long flags) dev_warn(drm->dev, "Invalid legacyfb_depth. > > Defaulting to 16bpp\n"); legacyfb_depth = 16; > > } > > + drm_helper_disable_unused_functions(drm); > > imxdrm->fbhelper = drm_fbdev_cma_init(drm, legacyfb_depth, > > drm->mode_config.num_crtc, MAX_CRTC); > > if (IS_ERR(imxdrm->fbhelper)) { > > diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c > > index 1469987949d8..506b5626f3ed 100644 > > --- a/drivers/gpu/drm/sti/sti_drv.c > > +++ b/drivers/gpu/drm/sti/sti_drv.c > > @@ -160,6 +160,7 @@ static int sti_load(struct drm_device *dev, unsigned > > long flags) > > > > drm_mode_config_reset(dev); > > > > + drm_helper_disable_unused_functions(dev); > > drm_fbdev_cma_init(dev, 32, > > dev->mode_config.num_crtc, > > dev->mode_config.num_connector); > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 876cad58b1f9..24be31d69701 > > 100644 > > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > > @@ -294,6 +294,7 @@ static int tilcdc_load(struct drm_device *dev, unsigned > > long flags) break; > > } > > > > + drm_helper_disable_unused_functions(dev); > > priv->fbdev = drm_fbdev_cma_init(dev, bpp, > > dev->mode_config.num_crtc, > > dev->mode_config.num_connector); > > -- > Regards, > > Laurent Pinchart > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Fri, 15 Jan 2016 11:17:30 +0100 Subject: [PATCH v2 13/26] drm/fb_cma_helper: Remove implicit call to disable_unused_functions In-Reply-To: <2014724.QmjXVju9UW@avalon> References: <1452785109-6172-1-git-send-email-maxime.ripard@free-electrons.com> <1452785109-6172-14-git-send-email-maxime.ripard@free-electrons.com> <2014724.QmjXVju9UW@avalon> Message-ID: <20160115101730.GH19130@phenom.ffwll.local> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 15, 2016 at 01:13:05AM +0200, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Thursday 14 January 2016 16:24:56 Maxime Ripard wrote: > > The drm_fbdev_cma_init function always calls the > > drm_helper_disable_unused_functions. Since it's part of the usual probe > > process, all the drivers using that helper will end up having their encoder > > and CRTC disable functions called at probe if their device has not been > > reported as enabled. > > > > This could be fixed by reading out from the registers the current state of > > the device if it is enabled, but even that will not handle the case where > > the device is actually disabled. > > > > Moreover, the drivers using the atomic modesetting expect that their enable > > and disable callback to be called when the device is already enabled or > > disabled (respectively). > > > > We can however fix this issue by moving the call to > > drm_helper_disable_unused_functions out of drm_fbdev_cma_init and make the > > drivers needing it (all the drivers calling drm_fbdev_cma_init and not > > using the atomic modesetting) explicitly call it. > > I'd rather add it to all drivers that call drm_fbdev_cma_init(). All the > atomic ones must have special code to cope with it that could be rendered > useless by the removal of the drm_helper_disable_unused_functions() call. That > code should be removed too, and it would be easier to check drivers one by one > and fixing them individually (outside of this patch series, unless you insist > ;-)) when removing the explicit drm_helper_disable_unused_functions() call. I had the same thought, but figured there's really no good reason ever to do this. I suspect most of that disable_unused_function stuff we have all over is supreme cargo-cult anyway ;-) > Other than that the patch looks fine to me. So went ahead and applied to drm-misc. -Daniel > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/drm_fb_cma_helper.c | 3 --- > > drivers/gpu/drm/imx/imx-drm-core.c | 1 + > > drivers/gpu/drm/sti/sti_drv.c | 1 + > > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 1 + > > 4 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c > > b/drivers/gpu/drm/drm_fb_cma_helper.c index c19a62561183..daa98d881142 > > 100644 > > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > > @@ -348,9 +348,6 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct > > drm_device *dev, > > > > } > > > > - /* disable all the possible outputs/crtcs before entering KMS mode */ > > - drm_helper_disable_unused_functions(dev); > > - > > ret = drm_fb_helper_initial_config(helper, preferred_bpp); > > if (ret < 0) { > > dev_err(dev->dev, "Failed to set initial hw configuration.\n"); > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c > > b/drivers/gpu/drm/imx/imx-drm-core.c index 7b990b4e96d2..e1db57791fc9 > > 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -312,6 +312,7 @@ static int imx_drm_driver_load(struct drm_device *drm, > > unsigned long flags) dev_warn(drm->dev, "Invalid legacyfb_depth. > > Defaulting to 16bpp\n"); legacyfb_depth = 16; > > } > > + drm_helper_disable_unused_functions(drm); > > imxdrm->fbhelper = drm_fbdev_cma_init(drm, legacyfb_depth, > > drm->mode_config.num_crtc, MAX_CRTC); > > if (IS_ERR(imxdrm->fbhelper)) { > > diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c > > index 1469987949d8..506b5626f3ed 100644 > > --- a/drivers/gpu/drm/sti/sti_drv.c > > +++ b/drivers/gpu/drm/sti/sti_drv.c > > @@ -160,6 +160,7 @@ static int sti_load(struct drm_device *dev, unsigned > > long flags) > > > > drm_mode_config_reset(dev); > > > > + drm_helper_disable_unused_functions(dev); > > drm_fbdev_cma_init(dev, 32, > > dev->mode_config.num_crtc, > > dev->mode_config.num_connector); > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 876cad58b1f9..24be31d69701 > > 100644 > > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > > @@ -294,6 +294,7 @@ static int tilcdc_load(struct drm_device *dev, unsigned > > long flags) break; > > } > > > > + drm_helper_disable_unused_functions(dev); > > priv->fbdev = drm_fbdev_cma_init(dev, bpp, > > dev->mode_config.num_crtc, > > dev->mode_config.num_connector); > > -- > Regards, > > Laurent Pinchart > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 13/26] drm/fb_cma_helper: Remove implicit call to disable_unused_functions Date: Fri, 15 Jan 2016 11:17:30 +0100 Message-ID: <20160115101730.GH19130@phenom.ffwll.local> References: <1452785109-6172-1-git-send-email-maxime.ripard@free-electrons.com> <1452785109-6172-14-git-send-email-maxime.ripard@free-electrons.com> <2014724.QmjXVju9UW@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <2014724.QmjXVju9UW@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Thomas Petazzoni , devicetree@vger.kernel.org, Wynter Woods , Mike Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alexander Kaplan , Hans de Goede , linux-sunxi@googlegroups.com, Maxime Ripard , Chen-Yu Tsai , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gRnJpLCBKYW4gMTUsIDIwMTYgYXQgMDE6MTM6MDVBTSArMDIwMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBIaSBNYXhpbWUsCj4gCj4gVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCj4gCj4g T24gVGh1cnNkYXkgMTQgSmFudWFyeSAyMDE2IDE2OjI0OjU2IE1heGltZSBSaXBhcmQgd3JvdGU6 Cj4gPiBUaGUgZHJtX2ZiZGV2X2NtYV9pbml0IGZ1bmN0aW9uIGFsd2F5cyBjYWxscyB0aGUKPiA+ IGRybV9oZWxwZXJfZGlzYWJsZV91bnVzZWRfZnVuY3Rpb25zLiBTaW5jZSBpdCdzIHBhcnQgb2Yg dGhlIHVzdWFsIHByb2JlCj4gPiBwcm9jZXNzLCBhbGwgdGhlIGRyaXZlcnMgdXNpbmcgdGhhdCBo ZWxwZXIgd2lsbCBlbmQgdXAgaGF2aW5nIHRoZWlyIGVuY29kZXIKPiA+IGFuZCBDUlRDIGRpc2Fi bGUgZnVuY3Rpb25zIGNhbGxlZCBhdCBwcm9iZSBpZiB0aGVpciBkZXZpY2UgaGFzIG5vdCBiZWVu Cj4gPiByZXBvcnRlZCBhcyBlbmFibGVkLgo+ID4gCj4gPiBUaGlzIGNvdWxkIGJlIGZpeGVkIGJ5 IHJlYWRpbmcgb3V0IGZyb20gdGhlIHJlZ2lzdGVycyB0aGUgY3VycmVudCBzdGF0ZSBvZgo+ID4g dGhlIGRldmljZSBpZiBpdCBpcyBlbmFibGVkLCBidXQgZXZlbiB0aGF0IHdpbGwgbm90IGhhbmRs ZSB0aGUgY2FzZSB3aGVyZQo+ID4gdGhlIGRldmljZSBpcyBhY3R1YWxseSBkaXNhYmxlZC4KPiA+ IAo+ID4gTW9yZW92ZXIsIHRoZSBkcml2ZXJzIHVzaW5nIHRoZSBhdG9taWMgbW9kZXNldHRpbmcg ZXhwZWN0IHRoYXQgdGhlaXIgZW5hYmxlCj4gPiBhbmQgZGlzYWJsZSBjYWxsYmFjayB0byBiZSBj YWxsZWQgd2hlbiB0aGUgZGV2aWNlIGlzIGFscmVhZHkgZW5hYmxlZCBvcgo+ID4gZGlzYWJsZWQg KHJlc3BlY3RpdmVseSkuCj4gPiAKPiA+IFdlIGNhbiBob3dldmVyIGZpeCB0aGlzIGlzc3VlIGJ5 IG1vdmluZyB0aGUgY2FsbCB0bwo+ID4gZHJtX2hlbHBlcl9kaXNhYmxlX3VudXNlZF9mdW5jdGlv bnMgb3V0IG9mIGRybV9mYmRldl9jbWFfaW5pdCBhbmQgbWFrZSB0aGUKPiA+IGRyaXZlcnMgbmVl ZGluZyBpdCAoYWxsIHRoZSBkcml2ZXJzIGNhbGxpbmcgZHJtX2ZiZGV2X2NtYV9pbml0IGFuZCBu b3QKPiA+IHVzaW5nIHRoZSBhdG9taWMgbW9kZXNldHRpbmcpIGV4cGxpY2l0bHkgY2FsbCBpdC4K PiAKPiBJJ2QgcmF0aGVyIGFkZCBpdCB0byBhbGwgZHJpdmVycyB0aGF0IGNhbGwgZHJtX2ZiZGV2 X2NtYV9pbml0KCkuIEFsbCB0aGUgCj4gYXRvbWljIG9uZXMgbXVzdCBoYXZlIHNwZWNpYWwgY29k ZSB0byBjb3BlIHdpdGggaXQgdGhhdCBjb3VsZCBiZSByZW5kZXJlZCAKPiB1c2VsZXNzIGJ5IHRo ZSByZW1vdmFsIG9mIHRoZSBkcm1faGVscGVyX2Rpc2FibGVfdW51c2VkX2Z1bmN0aW9ucygpIGNh bGwuIFRoYXQgCj4gY29kZSBzaG91bGQgYmUgcmVtb3ZlZCB0b28sIGFuZCBpdCB3b3VsZCBiZSBl YXNpZXIgdG8gY2hlY2sgZHJpdmVycyBvbmUgYnkgb25lIAo+IGFuZCBmaXhpbmcgdGhlbSBpbmRp dmlkdWFsbHkgKG91dHNpZGUgb2YgdGhpcyBwYXRjaCBzZXJpZXMsIHVubGVzcyB5b3UgaW5zaXN0 IAo+IDstKSkgd2hlbiByZW1vdmluZyB0aGUgZXhwbGljaXQgZHJtX2hlbHBlcl9kaXNhYmxlX3Vu dXNlZF9mdW5jdGlvbnMoKSBjYWxsLiAKCkkgaGFkIHRoZSBzYW1lIHRob3VnaHQsIGJ1dCBmaWd1 cmVkIHRoZXJlJ3MgcmVhbGx5IG5vIGdvb2QgcmVhc29uIGV2ZXIgdG8KZG8gdGhpcy4gSSBzdXNw ZWN0IG1vc3Qgb2YgdGhhdCBkaXNhYmxlX3VudXNlZF9mdW5jdGlvbiBzdHVmZiB3ZSBoYXZlIGFs bApvdmVyIGlzIHN1cHJlbWUgY2FyZ28tY3VsdCBhbnl3YXkgOy0pCgo+IE90aGVyIHRoYW4gdGhh dCB0aGUgcGF0Y2ggbG9va3MgZmluZSB0byBtZS4KClNvIHdlbnQgYWhlYWQgYW5kIGFwcGxpZWQg dG8gZHJtLW1pc2MuCi1EYW5pZWwKCj4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNYXhpbWUgUmlwYXJk IDxtYXhpbWUucmlwYXJkQGZyZWUtZWxlY3Ryb25zLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMv Z3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jIHwgMyAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0v aW14L2lteC1kcm0tY29yZS5jICB8IDEgKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2Ry di5jICAgICAgIHwgMSArCj4gPiAgZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90aWxjZGNfZHJ2LmMg fCAxICsKPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMo LSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBl ci5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jIGluZGV4IGMxOWE2 MjU2MTE4My4uZGFhOThkODgxMTQyCj4gPiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fZmJfY21hX2hlbHBlci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2Nt YV9oZWxwZXIuYwo+ID4gQEAgLTM0OCw5ICszNDgsNiBAQCBzdHJ1Y3QgZHJtX2ZiZGV2X2NtYSAq ZHJtX2ZiZGV2X2NtYV9pbml0KHN0cnVjdAo+ID4gZHJtX2RldmljZSAqZGV2LAo+ID4gCj4gPiAg CX0KPiA+IAo+ID4gLQkvKiBkaXNhYmxlIGFsbCB0aGUgcG9zc2libGUgb3V0cHV0cy9jcnRjcyBi ZWZvcmUgZW50ZXJpbmcgS01TIG1vZGUgKi8KPiA+IC0JZHJtX2hlbHBlcl9kaXNhYmxlX3VudXNl ZF9mdW5jdGlvbnMoZGV2KTsKPiA+IC0KPiA+ICAJcmV0ID0gZHJtX2ZiX2hlbHBlcl9pbml0aWFs X2NvbmZpZyhoZWxwZXIsIHByZWZlcnJlZF9icHApOwo+ID4gIAlpZiAocmV0IDwgMCkgewo+ID4g IAkJZGV2X2VycihkZXYtPmRldiwgIkZhaWxlZCB0byBzZXQgaW5pdGlhbCBodyBjb25maWd1cmF0 aW9uLlxuIik7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2lteC9pbXgtZHJtLWNv cmUuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaW14L2lteC1kcm0tY29yZS5jIGluZGV4IDdiOTkw YjRlOTZkMi4uZTFkYjU3NzkxZmM5Cj4gPiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pbXgvaW14LWRybS1jb3JlLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pbXgvaW14LWRy bS1jb3JlLmMKPiA+IEBAIC0zMTIsNiArMzEyLDcgQEAgc3RhdGljIGludCBpbXhfZHJtX2RyaXZl cl9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkcm0sCj4gPiB1bnNpZ25lZCBsb25nIGZsYWdzKSBk ZXZfd2Fybihkcm0tPmRldiwgIkludmFsaWQgbGVnYWN5ZmJfZGVwdGguIAo+ID4gRGVmYXVsdGlu ZyB0byAxNmJwcFxuIik7IGxlZ2FjeWZiX2RlcHRoID0gMTY7Cj4gPiAgCX0KPiA+ICsJZHJtX2hl bHBlcl9kaXNhYmxlX3VudXNlZF9mdW5jdGlvbnMoZHJtKTsKPiA+ICAJaW14ZHJtLT5mYmhlbHBl ciA9IGRybV9mYmRldl9jbWFfaW5pdChkcm0sIGxlZ2FjeWZiX2RlcHRoLAo+ID4gIAkJCQlkcm0t Pm1vZGVfY29uZmlnLm51bV9jcnRjLCBNQVhfQ1JUQyk7Cj4gPiAgCWlmIChJU19FUlIoaW14ZHJt LT5mYmhlbHBlcikpIHsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9k cnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2Rydi5jCj4gPiBpbmRleCAxNDY5OTg3OTQ5 ZDguLjUwNmI1NjI2ZjNlZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3Rp X2Rydi5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9kcnYuYwo+ID4gQEAgLTE2 MCw2ICsxNjAsNyBAQCBzdGF0aWMgaW50IHN0aV9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHVuc2lnbmVkCj4gPiBsb25nIGZsYWdzKQo+ID4gCj4gPiAgCWRybV9tb2RlX2NvbmZpZ19yZXNl dChkZXYpOwo+ID4gCj4gPiArCWRybV9oZWxwZXJfZGlzYWJsZV91bnVzZWRfZnVuY3Rpb25zKGRl dik7Cj4gPiAgCWRybV9mYmRldl9jbWFfaW5pdChkZXYsIDMyLAo+ID4gIAkJCSAgIGRldi0+bW9k ZV9jb25maWcubnVtX2NydGMsCj4gPiAgCQkJICAgZGV2LT5tb2RlX2NvbmZpZy5udW1fY29ubmVj dG9yKTsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19kcnYu Ywo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19kcnYuYyBpbmRleCA4NzZjYWQ1 OGIxZjkuLjI0YmUzMWQ2OTcwMQo+ID4gMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v dGlsY2RjL3RpbGNkY19kcnYuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90aWxj ZGNfZHJ2LmMKPiA+IEBAIC0yOTQsNiArMjk0LDcgQEAgc3RhdGljIGludCB0aWxjZGNfbG9hZChz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZAo+ID4gbG9uZyBmbGFncykgYnJlYWs7Cj4g PiAgCX0KPiA+IAo+ID4gKwlkcm1faGVscGVyX2Rpc2FibGVfdW51c2VkX2Z1bmN0aW9ucyhkZXYp Owo+ID4gIAlwcml2LT5mYmRldiA9IGRybV9mYmRldl9jbWFfaW5pdChkZXYsIGJwcCwKPiA+ICAJ CQlkZXYtPm1vZGVfY29uZmlnLm51bV9jcnRjLAo+ID4gIAkJCWRldi0+bW9kZV9jb25maWcubnVt X2Nvbm5lY3Rvcik7Cj4gCj4gLS0gCj4gUmVnYXJkcywKPiAKPiBMYXVyZW50IFBpbmNoYXJ0Cj4g CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK