From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 13001E00BD0; Fri, 15 Jan 2016 05:04:22 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.65 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 3EF3FE007EA for ; Fri, 15 Jan 2016 05:04:19 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 15 Jan 2016 05:04:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,299,1449561600"; d="scan'208";a="893812964" Received: from linux.intel.com ([10.23.219.25]) by fmsmga002.fm.intel.com with ESMTP; 15 Jan 2016 05:04:18 -0800 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id 3CAD76A4004; Fri, 15 Jan 2016 05:52:14 -0800 (PST) Date: Fri, 15 Jan 2016 13:07:48 +0200 From: Ed Bartosh To: Elliot Smith Message-ID: <20160115110748.GA22249@linux.intel.com> References: <1452858230-31457-1-git-send-email-elliot.smith@intel.com> MIME-Version: 1.0 In-Reply-To: <1452858230-31457-1-git-send-email-elliot.smith@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: toaster@yoctoproject.org Subject: Re: [review-request][PATCH 00/23][V2] Convert projects and builds pages to ToasterTable X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: ed.bartosh@linux.intel.com List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2016 13:04:22 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Patchset looks ok to me. Submitted upstream. Regards, Ed On Fri, Jan 15, 2016 at 11:43:27AM +0000, Elliot Smith wrote: > V2: > > Minor code formatting and fixes in line with code review by Ed Bartosh. > > V1: > > Many of the tables displayed by Toaster are backed by ToasterTable, but some > of the key ones (like "projects", "all builds", and "project builds") aren't. > > This makes it difficult to keep styling consistent between tables, as some > are styled by making changes to ToasterTable, while others are styled > by modifying Django templates. > > Improve the consistency and maintainability of these tables by converting > them to use ToasterTable. > > Note that this patchset also reworks the ToasterTable API so that we can easily > support different column filter types. > > To test: > > 1. Open the "projects", "all builds" and "project builds" pages in Toaster. > 2. Check that the column filtering and sorting works correctly, and projects/builds > display correctly. > > Changes since ea666f6 (toaster-next) are in > git://git.yoctoproject.org/poky-contrib, elliot/toaster/tables-8738 > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/tables-8738 > > Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8738 > > Elliot Smith (23): > toaster: toastergui: use ToasterTable for projects page > toaster: move image file suffix list to model > toaster: check inferred file suffixes against list of known types > toaster: toastergui: switch projects/ view to ToasterTable > toaster: toastergui: use event delegates for hover help elements > toaster: toastergui: convert all builds page to ToasterTable > toaster: toastergui: refactor ToasterTable filtering > toaster: toastergui: switch off filter highlights when inactive > toaster: toastergui: show recent builds on all builds page > toaster: toastergui: implement date range filters for builds > toaster: toastergui: implement "today" and "yesterday" filters > toaster: toastergui: convert project builds page to ToasterTable > toaster: toastergui: don't hide all elements with .col class > toaster: toastergui: ensure filter_value updates > toaster: toastergui: streamline construction of filter objects > toaster: toastergui: serialise decimals correctly > toaster: toastergui: set default visible and hideable columns > toaster: toastergui: mute label for filter actions with no records > toaster: toastergui: make "Apply" button state depend on filter range > toaster: toastergui: fix error and warning counts for builds > toaster: toastergui: remove unused views and template code > toaster: tests: fix Django tests for new ToasterTable pages > toaster: toastergui: code formatting and clean-up > > .../contrib/django-aggregate-if-master/.gitignore | 10 - > .../contrib/django-aggregate-if-master/.travis.yml | 50 -- > .../contrib/django-aggregate-if-master/LICENSE | 21 - > .../contrib/django-aggregate-if-master/README.rst | 156 ---- > .../django-aggregate-if-master/aggregate_if.py | 164 ---- > .../contrib/django-aggregate-if-master/runtests.py | 48 -- > .../contrib/django-aggregate-if-master/setup.py | 33 - > .../contrib/django-aggregate-if-master/tox.ini | 198 ----- > bitbake/lib/toaster/orm/models.py | 103 ++- > .../lib/toaster/toastergui/static/js/libtoaster.js | 6 +- > .../toaster/toastergui/static/js/projecttopbar.js | 9 + > bitbake/lib/toaster/toastergui/static/js/table.js | 325 ++++++-- > bitbake/lib/toaster/toastergui/tablefilter.py | 292 +++++++ > bitbake/lib/toaster/toastergui/tables.py | 858 +++++++++++++++++++-- > .../toastergui/templates/baseprojectpage.html | 1 + > .../toastergui/templates/builds-toastertable.html | 48 ++ > .../lib/toaster/toastergui/templates/builds.html | 125 --- > .../toaster/toastergui/templates/mrb_section.html | 4 +- > .../templates/projectbuilds-toastertable.html | 56 ++ > .../templates/projects-toastertable.html | 36 + > .../lib/toaster/toastergui/templates/projects.html | 92 --- > .../toastergui/templates/toastertable-filter.html | 4 +- > .../toaster/toastergui/templates/toastertable.html | 7 +- > bitbake/lib/toaster/toastergui/tests.py | 265 +++++-- > bitbake/lib/toaster/toastergui/urls.py | 14 +- > bitbake/lib/toaster/toastergui/views.py | 491 +----------- > bitbake/lib/toaster/toastergui/widgets.py | 112 +-- > bitbake/lib/toaster/toastermain/settings.py | 9 - > 28 files changed, 1898 insertions(+), 1639 deletions(-) > delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/.gitignore > delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/.travis.yml > delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/LICENSE > delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/README.rst > delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/aggregate_if.py > delete mode 100755 bitbake/lib/toaster/contrib/django-aggregate-if-master/runtests.py > delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/setup.py > delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/tox.ini > create mode 100644 bitbake/lib/toaster/toastergui/tablefilter.py > create mode 100644 bitbake/lib/toaster/toastergui/templates/builds-toastertable.html > delete mode 100644 bitbake/lib/toaster/toastergui/templates/builds.html > create mode 100644 bitbake/lib/toaster/toastergui/templates/projectbuilds-toastertable.html > create mode 100644 bitbake/lib/toaster/toastergui/templates/projects-toastertable.html > delete mode 100644 bitbake/lib/toaster/toastergui/templates/projects.html > > -- > Elliot Smith > Software Engineer > Intel OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster -- -- Regards, Ed