All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	xen-devel@lists.xensource.com,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] QEMU as non-root and PCI passthrough do not mix
Date: Fri, 15 Jan 2016 09:29:55 -0500	[thread overview]
Message-ID: <20160115142955.GD19934@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.02.1601151413520.16178@kaball.uk.xensource.com>

On Fri, Jan 15, 2016 at 02:14:40PM +0000, Stefano Stabellini wrote:
> On Thu, 14 Jan 2016, Ian Jackson wrote:
> > Stefano Stabellini writes ("Re: [PATCH] QEMU as non-root and PCI passthrough do not mix"):
> > > On Thu, 14 Jan 2016, Ian Campbell wrote:
> > > > What if b_info->device_model_user is NULL or == "root"? Doesn't this warn
> > > > even then?
> > > 
> > > I meant to warn even if device_model_user is NULL because it is the
> > > default and I think it is fair to inform the user about this. But I
> > > think you are right that we don't want to warn if device_model_user is
> > > specified as "root".
> > 
> > Much of the logic here is upended by what is now my qemu privsep
> > series.  Is it really worth fine-tuning the default handling here ?
> 
> Fair enough.
> 
> Do you prefer the PCI passthrough case to be fixed now or after your
> series? In other words, do you prefer this patch to go in now, or after
> your series?

I hadn't chance to look at the patch but I was wondering if we also
take into account the pci-assign and pci-detach on a guest that booted
without PCI passthrough?

  reply	other threads:[~2016-01-15 14:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 16:52 [PATCH] QEMU as non-root and PCI passthrough do not mix Stefano Stabellini
2016-01-14 10:39 ` Ian Campbell
2016-01-14 17:32   ` Stefano Stabellini
2016-01-14 17:34     ` Ian Jackson
2016-01-15 14:14       ` Stefano Stabellini
2016-01-15 14:29         ` Konrad Rzeszutek Wilk [this message]
2016-01-15 14:49           ` Stefano Stabellini
2016-01-15 14:56             ` Ian Campbell
2016-01-14 17:40     ` Ian Campbell
2016-01-14 17:42       ` Ian Jackson
2016-01-15  9:53         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160115142955.GD19934@localhost.localdomain \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.