From: Jason Cooper <jason@lakedaemon.net>
To: Joe Perches <joe@perches.com>
Cc: Peter Senna Tschudin <peter.senna@collabora.com>,
thomas@winischhofer.net, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
sergei.shtylyov@cogentembedded.com,
Masahiro Yamada <yamada.m@jp.panasonic.com>
Subject: Re: [PATCH V2 0/7] usb-misc: sisusbvga: cleanup and bug fix
Date: Fri, 15 Jan 2016 18:07:24 +0000 [thread overview]
Message-ID: <20160115180724.GA29306@io.lakedaemon.net> (raw)
In-Reply-To: <1452880309.8586.56.camel@perches.com>
Hey Joe, Peter,
On Fri, Jan 15, 2016 at 09:51:49AM -0800, Joe Perches wrote:
> (cc'ing Masahiro Yamada and Jason Cooper for objdiff)
>
> On Fri, 2016-01-15 at 18:41 +0100, Peter Senna Tschudin wrote:
...
> As far as I know, gcc has never made guarantees about
> object output for the same input content.
True, we may want to reach out to the folks doing reproducible builds.
They may have seen/diagnosed/fixed this already.
> > # But here is the interesting part. Even compiling the exact same source code
> > # produces different results
> > $ git checkout -- .
> > $ md5sum drivers/usb/misc/sisusbvga/sisusb.c
> > d6ffbd44f3f1cf81fd55ce84441ab889 drivers/usb/misc/sisusbvga/sisusb.c
> >
> > $ make -j4 drivers/usb/misc/sisusbvga/sisusb.o
> > $ objdump -D drivers/usb/misc/sisusbvga/sisusb.o| \
> > sed "s/^[[:space:]]\+[0-9a-f]\+//" > /tmp/base_dump_again
> >
> > $ diff /tmp/base_dump /tmp/base_dump_again
> > 9135,9136c9135,9136
> > < : 8e 4d 31 mov 0x31(%rbp),%cs
> > < : 46 00 00 rex.RX add %r8b,(%rax)
> > ---
> > > : de 10 ficom (%rax)
> > > : 33 46 00 xor 0x0(%rsi),%eax
> > 9139c9139
> > < : 4b 00 00 rex.WXB add %al,(%r8)
> > ---
> > > : 00 4b 00 add %cl,0x0(%rbx)
Well, this clearly shows that the whitespace change is a red herring.
I'm just guessing here, but could you try with -j1 to see if you can
still reproduce this inconsistency?
Cleaning the tree between builds may also narrow down the suspects.
thx,
Jason.
prev parent reply other threads:[~2016-01-15 18:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 17:41 [PATCH V2 0/7] usb-misc: sisusbvga: cleanup and bug fix Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style: horizontal whitespace changes Peter Senna Tschudin
2016-01-15 17:56 ` Joe Perches
2016-01-15 18:09 ` Peter Senna
2016-01-15 18:21 ` Alan Stern
2016-01-15 17:41 ` [PATCH V2 2/7] usb-misc: sisusbvga: Fix coding style: vertical " Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 3/7] usb-misc: sisusbvga: Fix coding style: braces, parenthesis, comment Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 4/7] usb-misc: sisusbvga: Fix coding style: remove assignment from if tests Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 5/7] usb-misc: sisusbvga: Remove null test before calls to kfree() Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 6/7] usb-misc: sisusbvga: Remove memory allocation logs Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 7/7] usb-misc: sisusbvga: fix error path Peter Senna Tschudin
2016-01-15 17:51 ` [PATCH V2 0/7] usb-misc: sisusbvga: cleanup and bug fix Joe Perches
2016-01-15 18:07 ` Jason Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115180724.GA29306@io.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@collabora.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas@winischhofer.net \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.