From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753599AbcAOSHv (ORCPT ); Fri, 15 Jan 2016 13:07:51 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56563 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbcAOSHs (ORCPT ); Fri, 15 Jan 2016 13:07:48 -0500 Date: Fri, 15 Jan 2016 18:07:40 +0000 From: Mark Brown To: chenfeng Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, yudongbin@hisilicon.com, saberlily.xia@hisilicon.com, suzhuangluan@hisilicon.com, kong.kongxinwei@hisilicon.com, xuyiping@hisilicon.com, z.liuxinliang@hisilicon.com, puck.chenfeng@gmail.com, weidong2@hisilicon.com, w.f@huawei.com, qijiwen@hisilicon.com, peter.panshilin@hisilicon.com, dan.zhao@hisilicon.com, linuxarm@huawei.com, liguozhu@hisilicon.com Message-ID: <20160115180740.GD6588@sirena.org.uk> References: <1452514817-118311-1-git-send-email-puck.chen@hisilicon.com> <1452514817-118311-5-git-send-email-puck.chen@hisilicon.com> <20160111182444.GR6588@sirena.org.uk> <5694625B.9060304@hisilicon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kza01WAI6/G3rFVM" Content-Disposition: inline In-Reply-To: <5694625B.9060304@hisilicon.com> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kza01WAI6/G3rFVM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 12, 2016 at 10:18:03AM +0800, chenfeng wrote: > On 2016/1/12 2:24, Mark Brown wrote: > > On Mon, Jan 11, 2016 at 08:20:16PM +0800, Chen Feng wrote: > >> +config REGULATOR_HI655X > >> + tristate "Hisilicon HI655X PMIC regulators support" > >> + depends on ARCH_HISI || (COMPILE_TEST && ARM64) > > Why does this depend on ARM64? If it's needed it probably indicates a > > problem... > There will be compile warning with arch parisc. > Add the current support platform is ARM64. The whole point of COMPILE_TEST is to allow people who are working generally rather than with the particular hardware to build things to improve build test coverage when doing general kernel work. A warning on a very obscure architecture is really not a blocker here. > I am not sure about open coding regulators_node. > I take max8907-regulator.c for reference. The code there is: > 224 static int max8907_regulator_parse_dt(struct platform_device *pdev) The existance of older drivers that have not yet been converted to use newer core subsystem features is not a good reason to avoid using those core subsystem features. You'll commonly find this situation in the kernel. > Can you give me some references? Really thanks for your help. $ grep -l regulators_node drivers/regulator/*.c drivers/regulator/88pm800.c drivers/regulator/axp20x-regulator.c drivers/regulator/da9062-regulator.c drivers/regulator/isl9305.c drivers/regulator/max14577.c drivers/regulator/max77686.c drivers/regulator/max77693.c drivers/regulator/max77802.c drivers/regulator/mt6311-regulator.c drivers/regulator/of_regulator.c drivers/regulator/pv88060-regulator.c drivers/regulator/pv88090-regulator.c drivers/regulator/rn5t618-regulator.c drivers/regulator/rt5033-regulator.c drivers/regulator/sky81452-regulator.c drivers/regulator/tps65023-regulator.c drivers/regulator/tps65086-regulator.c drivers/regulator/tps65217-regulator.c --kza01WAI6/G3rFVM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWmTVrAAoJECTWi3JdVIfQ5VoH/iksklkenYPQsWThYBn51EnZ X5KbNyA56FEjWHUoQxA2EdPkzugsV0cwmSAD+UPi7cmiQZJc33BuijsVuiG+Olg+ xnOncltAA5TXCizYG/7+8Br2D3CMbY48NFrScWaI3nW5P+t1FRd2zG7RQk8I/CFh yokxKkIxyjXC9RASWAOGefpbzqcYQu2p4QErJSuc6uGx74gopOyjMZfXcxQbV8wJ Afm6CV0DVmnL4cyCMLzjzE39L/9UOSVPOopiHkCXozoomrZlWg3kFThWDiYRTj1v vaO5c806bSzIOgB1Ozwi2wW06+PGHyPhLDYOC2GHJopyjKiluIpHtoLGroI1Hr8= =iMo0 -----END PGP SIGNATURE----- --kza01WAI6/G3rFVM--