From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Date: Fri, 15 Jan 2016 19:07:33 +0000 Subject: Re: net/sctp: sctp_datamsg memory leak Message-Id: <20160115190733.GI6074@mrl.redhat.com> List-Id: References: <20160108152507.GB6074@mrl.redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dmitry Vyukov Cc: Vlad Yasevich , Neil Horman , "David S. Miller" , linux-sctp@vger.kernel.org, netdev , LKML , syzkaller , Kostya Serebryany , Alexander Potapenko , Sasha Levin , Eric Dumazet On Fri, Jan 15, 2016 at 07:55:56PM +0100, Dmitry Vyukov wrote: > On Fri, Jan 8, 2016 at 4:25 PM, Marcelo Ricardo Leitner > wrote: ... > >> \xe9\x32\ > >> xde\x36", > >> 251); > > > > Please clarify this line. It doesn't compile as-is and the len doesn't > > match the data itself. > > I am not sure why there a ! at the end of the line, it wasn't present > in my original program. > Here is a source that compiles for me with -Wall: > https://gist.githubusercontent.com/dvyukov/662ee19898ed25f7db31/raw/3a6cbfa462f8eba67fda90f16198c62159b6b42f/gistfile1.txt > Got it, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753432AbcAOTHk (ORCPT ); Fri, 15 Jan 2016 14:07:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54896 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbcAOTHi (ORCPT ); Fri, 15 Jan 2016 14:07:38 -0500 Date: Fri, 15 Jan 2016 17:07:33 -0200 From: Marcelo Ricardo Leitner To: Dmitry Vyukov Cc: Vlad Yasevich , Neil Horman , "David S. Miller" , linux-sctp@vger.kernel.org, netdev , LKML , syzkaller , Kostya Serebryany , Alexander Potapenko , Sasha Levin , Eric Dumazet Subject: Re: net/sctp: sctp_datamsg memory leak Message-ID: <20160115190733.GI6074@mrl.redhat.com> References: <20160108152507.GB6074@mrl.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2016 at 07:55:56PM +0100, Dmitry Vyukov wrote: > On Fri, Jan 8, 2016 at 4:25 PM, Marcelo Ricardo Leitner > wrote: ... > >> \xe9\x32\ > >> xde\x36", > >> 251); > > > > Please clarify this line. It doesn't compile as-is and the len doesn't > > match the data itself. > > I am not sure why there a ! at the end of the line, it wasn't present > in my original program. > Here is a source that compiles for me with -Wall: > https://gist.githubusercontent.com/dvyukov/662ee19898ed25f7db31/raw/3a6cbfa462f8eba67fda90f16198c62159b6b42f/gistfile1.txt > Got it, thanks