From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, tom@herbertland.com, kaber@trash.net,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
herbert@gondor.apana.org.au
Subject: Re: [PATCH net] netfilter: xt_TCPMSS: handle CHECKSUM_COMPLETE in tcpmss_tg6()
Date: Fri, 15 Jan 2016 21:04:16 +0100 [thread overview]
Message-ID: <20160115200416.GA2331@salvia> (raw)
In-Reply-To: <20160115.140449.1324683966791337294.davem@davemloft.net>
On Fri, Jan 15, 2016 at 02:04:49PM -0500, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 15 Jan 2016 09:18:44 -0800
>
> > On Fri, 2016-01-15 at 08:43 -0800, Tom Herbert wrote:
> >
> >> Probably should have a utility function do this. Maybe something like
> >> update_hdr_field(skb, old, new)? Could return new value so above could
> >> just be:
> >>
> >> ipv6h->payload_len = update_hdr_field(skb, ipv6h->payload_len,
> >> htons(ntohs(oldlen) + ret);
> >
> > Well, oldlen would still need to be ipv6h->payload_len
> >
> > Not sure a helper will be nice for a stable submission.
> >
> > Probably better for net-next ?
>
> Agreed. We already have those csum_replace{2,4}() helpers in net/checksum.h
> which we could augment with ones that can handle length changes too.
I'm going to place this into the nf tree, thanks!
prev parent reply other threads:[~2016-01-15 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 16:21 [PATCH net] netfilter: xt_TCPMSS: handle CHECKSUM_COMPLETE in tcpmss_tg6() Eric Dumazet
2016-01-15 16:43 ` Tom Herbert
2016-01-15 17:18 ` Eric Dumazet
2016-01-15 17:25 ` Tom Herbert
2016-01-15 19:04 ` David Miller
2016-01-15 20:04 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115200416.GA2331@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.