From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [git pull] vfs.git regression fix
Date: Fri, 15 Jan 2016 21:00:46 +0000 [thread overview]
Message-ID: <20160115210046.GG17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFwrubi+s4dF5_JqODkNGd-k-8+bkFVUaBvPPLD55Sx1Nw@mail.gmail.com>
On Fri, Jan 15, 2016 at 12:41:06PM -0800, Linus Torvalds wrote:
> Al,
> _please_ learn to be more careful about your pull requests.
>
> This one is garbage.
>
> Why?
>
> You ask me to pull from the wrong source. You ask me to pull from
>
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
>
> but that is some random state from January 2014. Two years ago.
>
> What you actually *meant* was apparently the "for-linus" branch, since
> that matches the shortlog and diffstat. But that's not what your pull
> request asked me to pull.
>
> This is not the first time. You seem to either use buggy scripts, or
> do this (wrong) by hand. Please fix whatever it is, so that I don't
> have to go look or guess after I notice that I pulled crap.
Buggy scripts, actually. The thing that generates them takes a branch
name as argument; turns out that it (pretty much by accident) treats the
missing argument as HEAD. Which tends to give reasonable diffstat and
shortlog, so I hadn't spotted the missing check until now.
Fixed. BTW, is there any better way to get the current branch name than
git branch |sed -ne '/\* /s///p'?
next prev parent reply other threads:[~2016-01-15 21:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 20:18 [git pull] vfs.git regression fix Al Viro
2016-01-15 20:41 ` Linus Torvalds
2016-01-15 21:00 ` Al Viro [this message]
2016-01-15 21:08 ` Linus Torvalds
2016-01-16 13:44 ` Al Viro
2016-01-16 19:05 ` Linus Torvalds
2016-01-18 7:49 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115210046.GG17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.