From: Florian Westphal <fw@strlen.de>
To: "stéphane bryant" <stephane.ml.bryant@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 3/3] netfilter: bridge: copy back VLAN header for bridge packet queued to userspace
Date: Sat, 16 Jan 2016 12:06:19 +0100 [thread overview]
Message-ID: <20160116110619.GA28299@breakpoint.cc> (raw)
In-Reply-To: <569A22C8.9030707@gmail.com>
stéphane bryant <stephane.ml.bryant@gmail.com> wrote:
Please don't top-post, thanks.
> Regarding the entire L2 header attribute. I assume it would be a
> separate attribute from the existing NFQA_HWADDR?
Yes, it would just contain mac header start to skb->data, i.e. without
VLAN header. VLAN header would go into a new attribute too.
> Or would it make sense
> to collapse these 2 into one (potentially with helpers to access each
> relevant field) to avoid duplicating information (and redundancy, and
> potential discrepancies)?
Yes but we cannot do it due to backwards compatibility.
We *can* omit NFQA_HWADDR in the family == NFPROTO_BRIDGE case of
course.
Thanks for working on this,
Florian
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-16 11:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 8:48 [PATCH nf-next 0/3] netfilter: bridge: add queuing to userspace for AF_BRIDGE family Stephane Bryant
2016-01-15 8:48 ` [PATCH nf-next 1/3] netfilter: bridge: add nf_afinfo to enable queuing to userspace Stephane Bryant
2016-01-15 9:06 ` kbuild test robot
2016-01-15 9:49 ` Florian Westphal
2016-01-20 14:34 ` stéphane bryant
2016-01-20 15:52 ` Florian Westphal
2016-01-15 8:48 ` [PATCH nf-next 2/3] netfilter: bridge: pull back mac header into skb queued " Stephane Bryant
2016-01-15 8:48 ` [PATCH nf-next 3/3] netfilter: bridge: copy back VLAN header for bridge packet " Stephane Bryant
2016-01-15 10:06 ` Florian Westphal
2016-01-15 10:49 ` Florian Westphal
2016-01-15 11:02 ` Pablo Neira Ayuso
2016-01-15 14:04 ` Florian Westphal
2016-01-15 16:33 ` Pablo Neira Ayuso
2016-01-16 11:00 ` stéphane bryant
2016-01-16 11:06 ` Florian Westphal [this message]
2016-01-23 9:30 ` stéphane bryant
2016-01-23 20:39 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160116110619.GA28299@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stephane.ml.bryant@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.