From: Andrew Lunn <andrew@lunn.ch>
To: Teresa Remmet <t.remmet@phytec.de>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: phy: smsc: Fix disabling energy detect mode
Date: Sat, 16 Jan 2016 18:11:49 +0100 [thread overview]
Message-ID: <20160116171149.GA9880@lunn.ch> (raw)
In-Reply-To: <1452849633-26877-1-git-send-email-t.remmet@phytec.de>
> +static void smsc_phy_remove(struct phy_device *phydev)
> +{
> + struct device *dev = &phydev->mdio.dev;
> + bool *priv = phydev->priv;
> +
> + if (priv)
> + devm_kfree(dev, priv);
> +}
Not needed, since this is the devm_ API.
>From a stylistic point of view, it might be better to define a
structure with a single member. It is what people expect a priv to be.
It keeps the maintenance burden lower if you do things in the normal
way.
Andrew
prev parent reply other threads:[~2016-01-16 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 9:20 [PATCH] net: phy: smsc: Fix disabling energy detect mode Teresa Remmet
2016-01-15 19:55 ` David Miller
2016-01-16 17:11 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160116171149.GA9880@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=t.remmet@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.