All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, ext4@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: introduce per-inode DAX enablement
Date: Sat, 16 Jan 2016 16:22:51 -0500	[thread overview]
Message-ID: <20160116212251.GC26427@thunk.org> (raw)
In-Reply-To: <1451886892-15548-4-git-send-email-david@fromorbit.com>

On Mon, Jan 04, 2016 at 04:54:52PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> Rather than just being able to turn DAX on and off via a mount
> option, some applications may only want to enable DAX for certain
> performance critical files in a filesystem.
> 
> This patch introduces a new inode flag to enable DAX in the v3 inode
> di_flags2 field. It adds support for setting and clearing flags in
> the di_flags2 field via the XFS_IOC_FSSETXATTR ioctl, and sets the
> S_DAX inode flag appropriately when it is seen.
> 
> When this flag is set on a directory, it acts as an "inherit flag".
> That is, inodes created in the directory will automatically inherit
> the on-disk inode DAX flag, enabling administrators to set up
> directory heirarchies that automatically use DAX. Setting this flag
> on an empty root directory will make the entire filesystem use DAX
> by default.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good to me.

Reviewed-by: Theodore Ts'o <tytso@mit.edu>

							- Ted

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs: introduce per-inode DAX enablement
Date: Sat, 16 Jan 2016 16:22:51 -0500	[thread overview]
Message-ID: <20160116212251.GC26427@thunk.org> (raw)
In-Reply-To: <1451886892-15548-4-git-send-email-david@fromorbit.com>

On Mon, Jan 04, 2016 at 04:54:52PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> Rather than just being able to turn DAX on and off via a mount
> option, some applications may only want to enable DAX for certain
> performance critical files in a filesystem.
> 
> This patch introduces a new inode flag to enable DAX in the v3 inode
> di_flags2 field. It adds support for setting and clearing flags in
> the di_flags2 field via the XFS_IOC_FSSETXATTR ioctl, and sets the
> S_DAX inode flag appropriately when it is seen.
> 
> When this flag is set on a directory, it acts as an "inherit flag".
> That is, inodes created in the directory will automatically inherit
> the on-disk inode DAX flag, enabling administrators to set up
> directory heirarchies that automatically use DAX. Setting this flag
> on an empty root directory will make the entire filesystem use DAX
> by default.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good to me.

Reviewed-by: Theodore Ts'o <tytso@mit.edu>

							- Ted

  reply	other threads:[~2016-01-16 21:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04  5:54 [PATCH 0/3] fs: FS_IOC_FS[GS]ETXATTR promotion Dave Chinner
2016-01-04  5:54 ` Dave Chinner
2016-01-04  5:54 ` [PATCH 1/3] fs: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR promotion Dave Chinner
2016-01-04  5:54   ` Dave Chinner
2016-01-16 21:22   ` Theodore Ts'o
2016-01-16 21:22     ` Theodore Ts'o
2016-01-04  5:54 ` [PATCH 2/3] xfs: use FS_XFLAG definitions directly Dave Chinner
2016-01-04  5:54   ` Dave Chinner
2016-01-16 21:22   ` Theodore Ts'o
2016-01-16 21:22     ` Theodore Ts'o
2016-01-04  5:54 ` [PATCH 3/3] xfs: introduce per-inode DAX enablement Dave Chinner
2016-01-04  5:54   ` Dave Chinner
2016-01-16 21:22   ` Theodore Ts'o [this message]
2016-01-16 21:22     ` Theodore Ts'o
2016-01-21 16:37   ` Dan Williams
2016-01-21 16:37     ` Dan Williams
2016-01-21 21:58     ` Dave Chinner
2016-01-21 21:58       ` Dave Chinner
2016-01-21 22:53       ` Dan Williams
2016-01-21 22:53         ` Dan Williams
2016-01-29 22:20         ` Dave Chinner
2016-01-29 22:20           ` Dave Chinner
2016-01-22  0:45   ` Darrick J. Wong
2016-01-22  0:45     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160116212251.GC26427@thunk.org \
    --to=tytso@mit.edu \
    --cc=david@fromorbit.com \
    --cc=ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.