From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKzFf-00024i-KM for qemu-devel@nongnu.org; Sun, 17 Jan 2016 21:09:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKzFc-0002Pl-Ci for qemu-devel@nongnu.org; Sun, 17 Jan 2016 21:09:03 -0500 Received: from ozlabs.org ([103.22.144.67]:58594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKzFb-0002PI-Qq for qemu-devel@nongnu.org; Sun, 17 Jan 2016 21:09:00 -0500 Date: Mon, 18 Jan 2016 12:52:38 +1100 From: David Gibson Message-ID: <20160118015238.GE9301@voom.fritz.box> References: <1452860484-12236-1-git-send-email-david@gibson.dropbear.id.au> <1452860484-12236-3-git-send-email-david@gibson.dropbear.id.au> <569A39A5.9000400@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b8GWCKCLzrXbuNet" Content-Disposition: inline In-Reply-To: <569A39A5.9000400@redhat.com> Subject: Re: [Qemu-devel] [PATCHv3 2/4] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, lcapitulino@redhat.com --b8GWCKCLzrXbuNet Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 16, 2016 at 01:37:57PM +0100, Thomas Huth wrote: > On 15.01.2016 13:21, David Gibson wrote: > > At present, the core device model code for 8250-like serial ports > > (serial.c) and the code for serial ports attached to ISA-style legacy IO > > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. > >=20 > > There are lots and lots of embedded platforms that have 8250-like serial > > ports but have never had anything resembling ISA legacy IO. Therefore, > > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > > disabled for platforms where it's not appropriate. > >=20 > > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > > CONFIG_SERIAL is enabled, excepting microblaze, moxie, or32, and > > xtensa. As best as I can tell, those platforms never used legacy ISA, > > and also don't include PCI support (which would allow connection of a > > PCI->ISA bridge and/or a southbridge including legacy ISA serial > > ports). > >=20 > > Signed-off-by: David Gibson > > --- > > default-configs/alpha-softmmu.mak | 1 + > > default-configs/arm-softmmu.mak | 1 + > > default-configs/i386-softmmu.mak | 1 + > > default-configs/mips-softmmu.mak | 1 + > > default-configs/mips64-softmmu.mak | 1 + > > default-configs/mips64el-softmmu.mak | 1 + > > default-configs/mipsel-softmmu.mak | 1 + > > default-configs/ppc-softmmu.mak | 1 + > > default-configs/ppc64-softmmu.mak | 1 + > > default-configs/ppcemb-softmmu.mak | 1 + > > default-configs/sh4-softmmu.mak | 1 + > > default-configs/sh4eb-softmmu.mak | 1 + > > default-configs/sparc64-softmmu.mak | 1 + > > default-configs/x86_64-softmmu.mak | 1 + > > hw/char/Makefile.objs | 3 ++- > > 15 files changed, 16 insertions(+), 1 deletion(-) > ... > > diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-soft= mmu.mak > > index d4d0f9b..13eb94f 100644 > > --- a/default-configs/ppc-softmmu.mak > > +++ b/default-configs/ppc-softmmu.mak > > @@ -45,5 +45,6 @@ CONFIG_PLATFORM_BUS=3Dy > > CONFIG_ETSEC=3Dy > > CONFIG_LIBDECNUMBER=3Dy > > # For PReP > > +CONFIG_SERIAL_ISA=3Dy > > CONFIG_MC146818RTC=3Dy > > CONFIG_ISA_TESTDEV=3Dy > > diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-= softmmu.mak > > index 70a89d1..3e243fd 100644 > > --- a/default-configs/ppc64-softmmu.mak > > +++ b/default-configs/ppc64-softmmu.mak > > @@ -50,6 +50,7 @@ CONFIG_LIBDECNUMBER=3Dy > > CONFIG_XICS=3D$(CONFIG_PSERIES) > > CONFIG_XICS_KVM=3D$(and $(CONFIG_PSERIES),$(CONFIG_KVM)) > > # For PReP > > +CONFIG_SERIAL_ISA=3Dy > > CONFIG_MC146818RTC=3Dy > > CONFIG_ISA_TESTDEV=3Dy > > CONFIG_MEM_HOTPLUG=3Dy >=20 > A little bit off-topic ... but maybe we should simply "include > ppc-softmmu.mak" in ppc64-softmmu.mak since the ppc64-softmmu is > supposed to offer all the 32 bit platforms, too? Then changes like this > would only affect one file instead of two. Um.. perhaps, but not really within the scope of this series. >=20 > ... > > diff --git a/hw/char/Makefile.objs b/hw/char/Makefile.objs > > index 5931cc8..be42d2f 100644 > > --- a/hw/char/Makefile.objs > > +++ b/hw/char/Makefile.objs > > @@ -2,7 +2,8 @@ common-obj-$(CONFIG_IPACK) +=3D ipoctal232.o > > common-obj-$(CONFIG_ESCC) +=3D escc.o > > common-obj-$(CONFIG_PARALLEL) +=3D parallel.o > > common-obj-$(CONFIG_PL011) +=3D pl011.o > > -common-obj-$(CONFIG_SERIAL) +=3D serial.o serial-isa.o > > +common-obj-$(CONFIG_SERIAL) +=3D serial.o > > +common-obj-$(CONFIG_SERIAL_ISA) +=3D serial-isa.o > > common-obj-$(CONFIG_SERIAL_PCI) +=3D serial-pci.o > > common-obj-$(CONFIG_VIRTIO) +=3D virtio-console.o > > common-obj-$(CONFIG_XILINX) +=3D xilinx_uartlite.o >=20 > Patch looks fine to me. >=20 > Reviewed-by: Thomas Huth >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --b8GWCKCLzrXbuNet Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWnEVmAAoJEGw4ysog2bOSeakP/A/JT4oUZtLyBpwv8TGFvaxh rad6BB32DvPOI0eeCGJTzaYdeiqMHKm6RHeppr136LP5ZiqIW44uFTKQcSGTxSuL YrfDJQV6RfE/hgcdeyXBpL9cA7+xtaSjyXI4GuIsZB6Kk3TCrYqXXR4j0+6ozKET wLt9nffgbGcnka2eulqI8RsGTJFt4oM0LTtVNxsGJNHhToMtRdfejbXYMOCNCXps QhP5zzrjFQU5p4tzqQv5lyCcRoRy+lJbx2mxPStHf8tg3/cBuOylfCnC+vlgQLOK 9liSL+PPKmziThZse/Z77CG9A8t4HMvEUjSbCXx2G2JswN1o7zLkfyzdOY+qJQB9 KC2NeMAFDxvK6K/3X0OYT+iCMIadsZlKG/IaTIh25a4OSvZ6BBbPWt+wCHb8E1FM lzcBWWE0lddsfztPPx3HgZTu8r/1ZIvTvYJPMRs4H/VkwPiHnpXVg45B7ekVVr6Z 0cciAfLk/q8MAdAxWuZ0/n7Vgt4WJv+FPClwo9tO9Ggo6fL+FsVjF3oUtq1Hsb4+ E5Gcj37ylt8wk9eodp9e+oNQ2XaLDSHfg2QTbRA0PvQFEQZtYchP3LHOxqeFY5gu 9xniLSx70muDu5XrU3+YAc/2KlQhhR+o0AkzotreK/S7d5gd3LDzeAk0u9UhE0/K G8iu9TJh76EEsVh21ql8 =bVFq -----END PGP SIGNATURE----- --b8GWCKCLzrXbuNet--