From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51431)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1aL4cf-0007Sx-J5
	for qemu-devel@nongnu.org; Mon, 18 Jan 2016 02:53:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1aL4cc-00083K-BZ
	for qemu-devel@nongnu.org; Mon, 18 Jan 2016 02:53:09 -0500
Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:57361)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1aL4cc-00082o-1E
	for qemu-devel@nongnu.org; Mon, 18 Jan 2016 02:53:06 -0500
Received: from localhost
	by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Mon, 18 Jan 2016 07:53:02 -0000
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6558A2190046
	for <qemu-devel@nongnu.org>; Mon, 18 Jan 2016 07:52:49 +0000 (GMT)
Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com
	[9.149.37.213])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u0I7r0LP7143732
	for <qemu-devel@nongnu.org>; Mon, 18 Jan 2016 07:53:00 GMT
Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u0I7r0bm026293
	for <qemu-devel@nongnu.org>; Mon, 18 Jan 2016 00:53:00 -0700
Date: Mon, 18 Jan 2016 08:52:51 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20160118085251.7eb41db3.cornelia.huck@de.ibm.com>
In-Reply-To: <20160115120143.GB2432@work-vm>
References: <1452083019-15141-1-git-send-email-dgilbert@redhat.com>
	<1452083019-15141-2-git-send-email-dgilbert@redhat.com>
	<871t9jhnfs.fsf@oc4731375738.ibm.com>
	<20160115092419.GA2432@work-vm> <20160115120143.GB2432@work-vm>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] migration/virtio: Remove simple
 .get/.put use
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: amit.shah@redhat.com, quintela@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, Sascha Silbe <silbe@linux.vnet.ibm.com>

On Fri, 15 Jan 2016 12:01:44 +0000
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:

> I misunderstood the vmstate macro definition when
> I reworked the virtio .get/.put - but I can't
> get it to break for me, which suggests I'm perhaps
> not managing to get that structure into being
> sent in my tests.

The first of the structures should be sent whenever virtio-1 is enabled
on the host. I think virtio-pci (unlike virtio-ccw) still defaults to
off?