From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [kvm-unit-tests PATCH v2 02/10] x86: move io.h to asm Date: Mon, 18 Jan 2016 17:43:16 +0100 Message-ID: <20160118164316.GA15204@potion.brq.redhat.com> References: <1452876695-9240-1-git-send-email-drjones@redhat.com> <1452876695-9240-3-git-send-email-drjones@redhat.com> <20160115213922.GA11566@potion.brq.redhat.com> <20160118135543.GD4075@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, pbonzini@redhat.com, mst@redhat.com, agordeev@redhat.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39272 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932203AbcARQnU (ORCPT ); Mon, 18 Jan 2016 11:43:20 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 299CA4463F for ; Mon, 18 Jan 2016 16:43:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160118135543.GD4075@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: 2016-01-18 14:55+0100, Andrew Jones: > On Fri, Jan 15, 2016 at 10:39:23PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: >> 2016-01-15 17:51+0100, Andrew Jones: >>> diff --git a/lib/x86/vm.h b/lib/x86/vm.h >>> +#define virt_to_phys virt_to_phys >>> +#define phys_to_virt phys_to_virt >>=20 >> Nitpick: if we always define all (both) functions, using two guardin= g >> #defines is pure waste. lib/asm-generic/io.h even has both function= s >> under one #ifndef virt_to_phys. (It would be better with a sensible >> name instead of virt_to_phys and if it was in lib/asm-generic/vm.h. = :]) >=20 > This is just a consistency with Linux thing again. If you want to dro= p > the #include "asm-generic/io.h" from lib/x86/asm/io.h, then these can > go away too. I wouldn't drop asm-generic/io.h, but #define phys_to_virt phys_to_virt because it's not consistent with Linux nor itself. This nitpick wasn't the reason I didn't review, so if you don't want to drop [1/10], Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99