All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG
Date: Mon, 18 Jan 2016 17:53:17 +0100	[thread overview]
Message-ID: <20160118165317.GC2614@jama> (raw)
In-Reply-To: <85829b7950f74cb41f39b5f1fbd8541bcb7b6d1e.1452848807.git.liezhi.yang@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]

On Fri, Jan 15, 2016 at 01:07:20AM -0800, Robert Yang wrote:
> The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev from
> PACKAGECONFIG, now add it back.

It was removed intentionally, because for systemd images there isn't
libgudev provider in oe-core, only in meta-oe.

RP's fix:
http://git.openembedded.org/openembedded-core/commit/?h=jethro&id=bc458ae9586b45b11b6908eadb31e94d892e698f

breaks the dependencies again, because when systemd is used there won't
be libgudev needed by gstreamer1.0-plugins-good

Please revert both "fixes"

Regards,

> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  .../gstreamer/gstreamer1.0-plugins-good.inc        |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
> index edaafe8..2f987b4 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
> @@ -11,7 +11,7 @@ inherit gettext
>  PACKAGECONFIG ??= " \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)} \
> -    orc cairo flac gdk-pixbuf jpeg libpng soup speex taglib v4l2\
> +    orc cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib v4l2 \
>      "
>  
>  X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
> -- 
> 1.7.9.5
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2016-01-18 16:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15  9:07 [jethro] [PATCH 0/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG Robert Yang
2016-01-15  9:07 ` [PATCH 1/1] " Robert Yang
2016-01-18 16:53   ` Martin Jansa [this message]
2016-01-18 17:52     ` Richard Purdie
2016-01-19  1:40       ` Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160118165317.GC2614@jama \
    --to=martin.jansa@gmail.com \
    --cc=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.