From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756198AbcARSDW (ORCPT ); Mon, 18 Jan 2016 13:03:22 -0500 Received: from casper.infradead.org ([85.118.1.10]:37486 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755170AbcARSDT (ORCPT ); Mon, 18 Jan 2016 13:03:19 -0500 Date: Mon, 18 Jan 2016 19:03:16 +0100 From: Peter Zijlstra To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, eranian@google.com, linux-kernel@vger.kernel.org, mingo@kernel.org, Andi Kleen Subject: Re: [PATCH 09/11] x86, perf: Support sysfs files depending on SMT status Message-ID: <20160118180316.GU6357@twins.programming.kicks-ass.net> References: <1452906773-7581-1-git-send-email-andi@firstfloor.org> <1452906773-7581-10-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452906773-7581-10-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2016 at 05:12:51PM -0800, Andi Kleen wrote: > From: Andi Kleen > > Add a way to show different sysfs events attributes depending on > HyperThreading is on or off. This is difficult to determine > early at boot, so we just do it dynamically when the sysfs > attribute is read. > > v2: > Compute HT status only once in CPU online/offline hooks. But we still have the 'duplicate' functionality in fixup_ht_bug() as reported last time. Please merge these two, we should not have 2 different means of detecting SMT.