From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLPYW-0005sC-A0 for qemu-devel@nongnu.org; Tue, 19 Jan 2016 01:14:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLPYV-0008AQ-2f for qemu-devel@nongnu.org; Tue, 19 Jan 2016 01:14:16 -0500 Date: Tue, 19 Jan 2016 16:00:25 +1100 From: David Gibson Message-ID: <20160119050025.GB27454@voom.redhat.com> References: <1453178361-24244-1-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bCsyhTFzCvuiizWE" Content-Disposition: inline In-Reply-To: <1453178361-24244-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH] spapr: Don't create ibm, dynamic-reconfiguration-memory w/o DR LMBs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --bCsyhTFzCvuiizWE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 19, 2016 at 10:09:21AM +0530, Bharata B Rao wrote: > If guest doesn't have any dynamically reconfigurable (DR) logical memory > blocks (LMB), then we shouldn't create ibm,dynamic-reconfiguration-memory > device tree node. >=20 > Signed-off-by: Bharata B Rao > --- > This applies against ppc-for-2.6 branch of David Gibson's tree. Applied to ppc-for-2.6, thanks. >=20 > hw/ppc/spapr.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 50e5a26..86e5023 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -763,6 +763,13 @@ static int spapr_populate_drconf_memory(sPAPRMachine= State *spapr, void *fdt) > int nr_nodes =3D nb_numa_nodes ? nb_numa_nodes : 1; > =20 > /* > + * Don't create the node if there are no DR LMBs. > + */ > + if (!nr_lmbs) { > + return 0; > + } > + > + /* > * Allocate enough buffer size to fit in ibm,dynamic-memory > * or ibm,associativity-lookup-arrays > */ > @@ -868,7 +875,7 @@ int spapr_h_cas_compose_response(sPAPRMachineState *s= papr, > _FDT((spapr_fixup_cpu_dt(fdt, spapr))); > } > =20 > - /* Generate memory nodes or ibm,dynamic-reconfiguration-memory node = */ > + /* Generate ibm,dynamic-reconfiguration-memory node if required */ > if (memory_update && smc->dr_lmb_enabled) { > _FDT((spapr_populate_drconf_memory(spapr, fdt))); > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --bCsyhTFzCvuiizWE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWncLpAAoJEGw4ysog2bOSRh8QAIzowr7ig71UHCWRg4OTi49z gxIFsekgr74AEPBhYzCYAuTZP57q4ZDscW37iZwhb+v9ng1+5C6iaD0+DYLw85cC lCEp9CI+YyOzF4g5T3KgnFukKV+1VU7RzkHuFQPUrt+SHaS+1rdW7npwiRlfbq5l rwWTz7bh9vFRkwEL3S/pwK3ZVKf2aWawhzXhzNiYQnWH8GbDRC6879hQ/4dURp+o fAUUIvU5YIAujsq3pS3/lrhqPtFWuVZovbcw9q/w69FGTtBDjJefBznoZAZB3nIZ P5JeRjQF5NqsiddRDF5EhRqh+3+csfhKGzd38GPwv+Q7gmzx2CVrzes8Iu2Whawz qsV55O6WlPZshvD6hg/F1z6viLg8Qf8nYTWSr6y7PhGZ77Oa39a1tUmXRSn4ulLZ X/Sw8MINoHXeZOCR/1PX6uh2yqExiaYg+EqnBbVbTUxOcAMzXhSmKSD9W8cMHIHr MMBFsauSpyWi6v3aDtXsKpdqrvHCjSn1BmW+X3JdlvWYR3DiLEINXw3XaOD2ookK 2Tcaw66RdPKLb+BotTdUk8fYI/xW7KbGiO4G4XV52vTqL8FxL1aoxzTaZ4yWMmjf OMun9oxs4AjDMcvED1eeYgLD9NjffXJkvNn6mPVt/fK5CGDS4y0jqhReIEqRh91l WILGu6Ky671h42I0sqL9 =pFM1 -----END PGP SIGNATURE----- --bCsyhTFzCvuiizWE--