From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLU0J-0003sP-B0 for qemu-devel@nongnu.org; Tue, 19 Jan 2016 05:59:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLU0F-0005gs-61 for qemu-devel@nongnu.org; Tue, 19 Jan 2016 05:59:15 -0500 Date: Tue, 19 Jan 2016 19:25:04 +1100 From: David Gibson Message-ID: <20160119082504.GD27454@voom.redhat.com> References: <1453174759-22837-1-git-send-email-david@gibson.dropbear.id.au> <1453174759-22837-9-git-send-email-david@gibson.dropbear.id.au> <87bn8idnd8.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ylS2wUBXLOxYXZFQ" Content-Disposition: inline In-Reply-To: <87bn8idnd8.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: lvivier@redhat.com, thuth@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org --ylS2wUBXLOxYXZFQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: > David Gibson writes: >=20 > > The functions for migrating the hash page table on pseries machine type > > (htab_save_setup() and htab_load()) can report some errors with an > > explicit fprintf() before returning an appropriate error code. Change = these > > to use error_report() instead. > > > > Signed-off-by: David Gibson > > Reviewed-by: Thomas Huth > > --- > > hw/ppc/spapr.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index 3cfacb9..1eb7d03 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c >=20 > Lost this hunk: >=20 > @@ -1309,8 +1309,9 @@ static int htab_save_setup(QEMUFile *f, void *opa= que) > spapr->htab_fd =3D kvmppc_get_htab_fd(false); > spapr->htab_fd_stale =3D false; > if (spapr->htab_fd < 0) { > - fprintf(stderr, "Unable to open fd for reading hash table = =66rom KVM: %s\n", > - strerror(errno)); > + error_report( > + "Unable to open fd for reading hash table from KVM: %s= ", > + strerror(errno)); > return -1; > } > } >=20 > Intentional? Yes. As noted in the cover letter, this conflicts with another series I'm working on, which will obsolete this change anyway. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ylS2wUBXLOxYXZFQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWnfLgAAoJEGw4ysog2bOSvbkP/j5FpBvw7vdobJhftSMKdyRI fZ7u4RkXPAjfqQENS2s2HQhBMfyMiFdB+8lEgVzqEzigwb56JHUVt3+3uq4ODHmP DZBOCkNsrqLRNzu+ZIbpZiXaX5RDf9EdFq4Hum87KQ0Fvav8oRZTOIuTpAFAtBeb TTJVRs5cfITCgxHmafG4WYS3FF+Q7eW6N79I55zZx8PSErqWIaFWQUJ/8yJlDhfM DtrBWQb7qwLwuh9YSPSp1Icfon4J2UQbgiG41ATJGBvdXFus48I3VKoED7nD6TUI o9Rwg31pVUTaEB8+ToC0a/dOBc9+O8Pywmftx8SLn1qPHAYbwRVuBnMGaADOG+kK xkYcmBMoHTjn2eGPKrH7RuOzMNDDO3UJfy7oVxYPPKFSy9/4DpexOMZYZZIynWEW 9YPd+vPQopPI4fZ9cvwLJB2akn71JHfPsHPE62/70XVpCFUTlXGLryByDo3ydZqZ sqYtUkRzQa/Etx2u49SicUWggiJ+mmnykB5spL21LzkDAuCdTMN6SoKnG1McOJQj 18wmaYjbGSlC8dDutzoFLY05dGblz2EQs+26CB3SQa5SLXFOQxbUdCyryjQH7AhK X5A0DD9M2BoAK7OjqGfnOkqvEa5dGubC82i9vYdcJ04x7oSX6fBzQfrYfiOQuFeJ 3aQIgR0taAlqk5ViO5lF =hQp9 -----END PGP SIGNATURE----- --ylS2wUBXLOxYXZFQ--