Re: [PATCH] drm: initialize default rotation value to DRM_ROTATE_0

From: Daniel Vetter <daniel@ffwll.ch>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: initialize default rotation value to DRM_ROTATE_0
Date: Tue, 19 Jan 2016 09:42:21 +0100	[thread overview]
Message-ID: <20160119084221.GP19130@phenom.ffwll.local> (raw)
In-Reply-To: <1453192008-13283-1-git-send-email-m.szyprowski@samsung.com>

On Tue, Jan 19, 2016 at 09:26:48AM +0100, Marek Szyprowski wrote:
> When no console framebuffer is enabled, the default plane state is
> defined by plane reset function. If driver uses generic helper, then
> rotation property is set to zero. This is not a valid value for that
> enum. This patch sets default rotation value to DRM_ROTATE_0.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Applied to drm-misc.
-Daniel

> ---
>  drivers/gpu/drm/drm_atomic_helper.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 268d37f26960..d0d4b2ff7c21 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -2526,8 +2526,10 @@ void drm_atomic_helper_plane_reset(struct drm_plane *plane)
>  	kfree(plane->state);
>  	plane->state = kzalloc(sizeof(*plane->state), GFP_KERNEL);
>  
> -	if (plane->state)
> +	if (plane->state) {
>  		plane->state->plane = plane;
> +		plane->state->rotation = BIT(DRM_ROTATE_0);
> +	}
>  }
>  EXPORT_SYMBOL(drm_atomic_helper_plane_reset);
>  
> -- 
> 1.9.2
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel