From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753872AbcASMjQ (ORCPT ); Tue, 19 Jan 2016 07:39:16 -0500 Received: from 8bytes.org ([81.169.241.247]:45047 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178AbcASMjE (ORCPT ); Tue, 19 Jan 2016 07:39:04 -0500 Date: Tue, 19 Jan 2016 13:39:00 +0100 From: Joerg Roedel To: Borislav Petkov Cc: X86 ML , LKML , David Kaplan , Tom Lendacky Subject: Re: [PATCH] x86/cpufeature: Add AMD AVIC bit Message-ID: <20160119123900.GZ18805@8bytes.org> References: <1452938292-12327-1-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452938292-12327-1-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 16, 2016 at 10:58:12AM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > CPUID Fn8000_000A_EDX[13] denotes support for AMD's Virtual Interrupt > controller, i.e., APIC virtualization. > > Cc: David Kaplan > Cc: Tom Lendacky > Signed-off-by: Borislav Petkov > --- > arch/x86/include/asm/cpufeature.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h > index 7ad8c9464297..bbf166e805be 100644 > --- a/arch/x86/include/asm/cpufeature.h > +++ b/arch/x86/include/asm/cpufeature.h > @@ -268,6 +268,7 @@ > #define X86_FEATURE_DECODEASSISTS (15*32+ 7) /* Decode Assists support */ > #define X86_FEATURE_PAUSEFILTER (15*32+10) /* filtered pause intercept */ > #define X86_FEATURE_PFTHRESHOLD (15*32+12) /* pause filter threshold */ > +#define X86_FEATURE_AVIC (15*32+13) /* Virtual Interrupt Controller */ That is not enough, you also need to add the feature to the scattered cpuid_bits in arch/x86/kernel/cpu/scattered.c. The cpuid Fn8000_000A_EDX is not mapped 1-1 into the x86_capability array. Joerg