From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [RFC 00/29] De-stage android's sync framework Date: Tue, 19 Jan 2016 13:23:09 -0200 Message-ID: <20160119152309.GA8217@joana> References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> <20160119110017.GZ19130@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yk0-f171.google.com (mail-yk0-f171.google.com [209.85.160.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0954472054 for ; Tue, 19 Jan 2016 07:23:14 -0800 (PST) Received: by mail-yk0-f171.google.com with SMTP id k129so628618013yke.0 for ; Tue, 19 Jan 2016 07:23:14 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160119110017.GZ19130@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLCAKCjIwMTYtMDEtMTkgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPjoK Cj4gT24gRnJpLCBKYW4gMTUsIDIwMTYgYXQgMTI6NTU6MTBQTSAtMDIwMCwgR3VzdGF2byBQYWRv dmFuIHdyb3RlOgo+ID4gRnJvbTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29s bGFib3JhLmNvLnVrPgo+ID4gCj4gPiBUaGlzIHBhdGNoIHNlcmllcyBkZS1zdGFnZSB0aGUgc3lu YyBmcmFtZXdvcmssIGFuZCBpbiBvcmRlciB0byBhY2NvbXBsaXNoIHRoYXQKPiA+IGEgYnVuY2gg b2YgY2xlYW51cHMvaW1wcm92ZW1lbnRzIG9uIHRoZSBzeW5jIGFuZCBmZW5jZSB3ZXJlIG1hZGUu Cj4gPiAKPiA+IFRoZSBzeW5jIGZyYW1ld29yayBjb250YWluZWQgc29tZSBhYnN0cmFjdGlvbnMg YXJvdW5kIHN0cnVjdCBmZW5jZSBhbmQgdGhvc2UKPiA+IHdlcmUgcmVtb3ZlZCBpbiB0aGUgZGUt c3RhZ2luZyBwcm9jZXNzIGFtb25nIG90aGVyIGNoYW5nZXM6Cj4gPiAKPiA+IFVzZXJzcGFjZSB2 aXNpYmxlIGNoYW5nZXMKPiA+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+IAo+ID4gICog VGhlIHN3X3N5bmMgZmlsZSB3YXMgbW92ZWQgZnJvbSAvZGV2L3N3X3N5bmMgdG8gPGRlYnVnZnM+ L3N5bmMvc3dfc3luYy4gTm8KPiA+ICBvdGhlciBjaGFuZ2UuCj4gPiAKPiA+IEtlcm5lbCBBUEkg Y2hhbmdlcwo+ID4gLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAKPiA+ICAqIHN0cnVjdCBzeW5jX3Rp bWVsaW5lIGlzIG5vdyBzdHJ1Y3QgZmVuY2VfdGltZWxpbmUKPiA+ICAqIHN5bmNfdGltZWxpbmVf b3BzIGlzIG5vdyBmZW5jZV90aW1lbGluZV9vcHMgYW5kIHRoZXkgbm93IGNhcnJ5IHN0cnVjdAo+ ID4gIGZlbmNlIGFzIHBhcmFtZXRlciBpbnN0ZWFkIG9mIHN0cnVjdCBzeW5jX3B0Cj4gPiAgKiBh IC5jbGVhbnVwKCkgZmVuY2Ugb3Agd2FzIGFkZGVkIHRvIGFsbG93IHN5bmNfZmVuY2UgdG8gcnVu IGEgY2xlYW51cCB3aGVuCj4gPiAgdGhlIGZlbmNlX3RpbWVsaW5lIGlzIGRlc3Ryb3llZAo+ID4g ICogYWRkZWQgZmVuY2VfYWRkX3VzZWRfZGF0YSgpIHRvIHBhc3MgYSBwcml2YXRlIHBvaW50IHRv IHN0cnVjdCBmZW5jZS4gVGhpcwo+ID4gIHBvaW50ZXIgaXMgc2VudCBiYWNrIG9uIHRoZSAuY2xl YW51cCBvcC4KPiA+ICAqIFRoZSBzeW5jIHRpbWVsaW5lIGZ1bmN0aW9uIHdlcmUgbW92ZWQgdG8g YmUgZmVuY2VfdGltZWxpbmUgZnVuY3Rpb25zOgo+ID4gCSAtIHN5bmNfdGltZWxpbmVfY3JlYXRl KCkJLT4gZmVuY2VfdGltZWxpbmVfY3JlYXRlKCkKPiA+IAkgLSBzeW5jX3RpbWVsaW5lX2dldCgp CQktPiBmZW5jZV90aW1lbGluZV9nZXQoKQo+ID4gCSAtIHN5bmNfdGltZWxpbmVfcHV0KCkJCS0+ IGZlbmNlX3RpbWVsaW5lX3B1dCgpCj4gPiAJIC0gc3luY190aW1lbGluZV9kZXN0cm95KCkJLT4g ZmVuY2VfdGltZWxpbmVfZGVzdHJveSgpCj4gPiAJIC0gc3luY190aW1lbGluZV9zaWduYWwoKQkt PiBmZW5jZV90aW1lbGluZV9zaWduYWwoKQo+ID4gCj4gPiAgICogc3luY19wdF9jcmVhdGUoKSB3 YXMgcmVwbGFjZWQgYmUgZmVuY2VfY3JlYXRlX29uX3RpbWVsaW5lKCkKPiA+IAo+ID4gSW50ZXJu YWwgY2hhbmdlcwo+ID4gLS0tLS0tLS0tLS0tLS0tLQo+ID4gCj4gPiAgKiBmZW5jZV90aW1lbGlu ZV9vcHMgd2FzIHJlbW92ZWQgaW4gZmF2b3Igb2YgZGlyZWN0IHVzZSBmZW5jZV9vcHMKPiA+ICAq IGZlbmNlIGRlZmF1bHQgZnVuY3Rpb25zIHdlcmUgY3JlYXRlZCBmb3IgZmVuY2Vfb3BzCj4gPiAg KiByZW1vdmVkIHN0cnVjdHMgc3luY19wdCwgc3dfc3luY190aW1lbGluZSBhbmQgc3dfc3luY19w dAo+IAo+IEJ1bmNoIG9mIGZhaXJseSByYW5kb20gY29tbWVudHMgYWxsIG92ZXI6Cj4gCj4gLSBp bmNsdWRlL3VhcGkvbGludXgvc3dfc3luYy5oIGltbyBzaG91bGQgYmUgZHJvcHBlZCwgaXQncyBq dXN0IGEgcHJpdmF0ZQo+ICAgZGVidWdmcyBpbnRlcmZhY2UgYmV0d2VlbiBmZW5jZSBmZHMgYW5k IHRoZSB0ZXN0c3VpdGUuIFNpbmNlIHRoZSBwbGFuIGlzCj4gICB0byBoYXZlIHRoZSB0ZXN0Y2Fz ZXMgaW50ZWdyYXRlZCBpbnRvIHRoZSBrZXJuZWwgdHJlZSB0b28gd2UgZG9uJ3QgbmVlZAo+ICAg YSBwdWJsaWMgaGVhZGVyLgo+IAo+IC0gc2ltaWxhciBmb3IgaW5jbHVkZS9saW51eC9zd19zeW5j LmggSW1vIHRoYXQgc2hvdWxkIGFsbCBiZSBtb3ZlZCBpbnRvCj4gICBzeW5jX2RlYnVnLmMuIFNh bWUgZm9yIHN3X3N5bmMuYywgdGhhdCBzaG91bGQgYWxsIGxhbmQgaW4gc3luY19kZWJ1Zwo+ICAg aW1vLCBhbmQgbWFkZSBvcHRpb25hbCB3aXRoIGEgS2NvbmZpZyBvcHRpb24uIEF0IGxlYXN0IHdl IHNob3VsZCByZXVzZQo+ICAgQ09ORklHX0RFQlVHRlMuCgpUaGVzZSB0d28gaXRlbXMgc291bmRz IHJlYXNvbmFibGUgdG8gbWUuCgo+IAo+IC0gZmVuY2VfY29udGV4dCBhbmQgZmVuY2VfdGltZWxp bmUgYXJlIHJlYWxseSB0aGUgc2FtZS4gdGltZWxpbmUgaGFzIHNvbWUKPiAgIHN1cGVyLWJhc2lj IHN1cHBvcnQgZm9yIGRvaW5nIHN3LW9ubHkgZmVuY2UgdGltZWxpbmVzLCBidXQgaW1vIHRoYXQn cwo+ICAgbm90IHJlYWxseSB3b3J0aCBrZWVwaW5nIChhbmQgaWYgc28gYmV0dGVyIHRvIGtlZXAg c2VwZXJhdGUgaW4gYQo+ICAgc3ctZmVuY2UuYyBvciBzaW1pbGFyLCBsaWtlIHNlcW5vLWZlbmNl LmMpLiBUaGUgb3RoZXIgbWFpbiB0aGluZwo+ICAgdGltZWxpbmUgcHJvdmlkZXMgaXMgc3VwcG9y dCB0byBjbGVhbiB1cCBmZW5jZXMgb24gYSB0aW1lbGluZS4gQW5kIGltbwo+ICAgdGhhdCBjbGVh bnVwIHNob3VsZCBiZSBkb25lIGJ5IHRoZSBjb3JlIGZlbmNlIHN1cHBvcnQsIG5vdCBieSB0aGUg YWRkLW9uCj4gICBzdHVmZi4KClllcywgdGhleSBhcmUuIEJ1dCBJIGN1cnJlbnRseSBkb2Vzbid0 IGtub3cgaG93IHRvIG1lcmdlIHRoZW0gYmVzdCwgc28gSQpkZWNpZGVkIHRvIGdvIGZvciBhIFJG QyBpbnN0ZWFkIG9mIHRyeWluZyBzb21lIGNyYXp5IHNvbHV0aW9uIHRvdWNoaW5nCmFsbCBmZW5j ZV9jb250ZXh0IHVzZXJzLgoKPiAKPiBJbnRlcmx1ZGUgYWJvdXQgZmVuY2UgY2xlYW51cCBvbiBk cml2ZXIgdW5sb2FkOgo+IAo+IFdvcmtpbmcgZHJpdmVycyBpbW8gc2hvdWxkIG5ldmVyIGNhbGwg dGltZWxpbmVfZGVzdHJveSB3aGVuIHRoZXJlJ3Mgc3RpbGwKPiBhbiB1bnNpZ25hbGxlZCBmZW5j ZSBhcm91bmQgZm9yIHRoYXQgdGltZWxpbmUvY29udGV4dC4gVGhhdCBqdXN0IG1lYW5zCj4gdGhl eSdyZSBicm9rZW4gYW5kIGZhaWxlZCB0byBjbGVhbiB1cCBhbGwgdGhlIHBlbmRpbmcgd29yay4g U28gdGhlIHByb2JsZW0KPiByZWFsbHkgaXMgb25seSB3aGF0IHRvIGRvIHdpdGggZmVuY2VzIHdo ZXJlIHRoZSBkcml2ZXIgZGlzYXBwZWFyZWQsIGFuZAo+IGZvciB0aGF0IHdlIGVzc2VudGlhbGx5 IG5lZWQgYSBmZW5jZV9yZXZva2UoKSBmdW5jdGlvbiAod2hpY2ggY291bGQgYmUKPiBjYWxsZWQg aW50ZXJuYWxseSBmcm9tIHRpbWVsaW5lX2ZyZWUpLiBTbyBoZXJlJ3Mgd2hhdCBJIHRoaW5rCj4g dGltZWxpbmVfZnJlZSBzaG91bGQgZG86Cj4gCj4gZm9yX2VhY2hfZmVuY2Vfb25fdGltZWwoKSB7 Cj4gCVdBUk5fT04oIWZlbmNlX2lzX3NpZ25hbGxlZCgpKTsKPiAKPiAJZmVuY2VfcmV2b2tlKGZl bmNlKTsKPiB9Cj4gCj4gSW1wbGVtZW50aW5nIGZlbmNlX3Jldm9rZSBpcyBhIGJpdCB0cmlja3kg c2luY2Ugd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhlCj4gbWVtb3J5IGNvbnRhaW5lZCAtPm9wcyBh bmQgc2ltaWxhciBzdHVmZiBkb2Vzbid0IGRpc2FwcGVhci4gU2ltcGxlc3QKPiBvcHRpb24gbWln aHQgYmUgdG8gZ3JhYiBhIHRlbXBvcmFyeSByZWZlcmVuY2UgKHVzaW5nCj4ga3JlZl9nZXRfdW5s ZXNzX3plcm8pLCBhbmQgdGhlbiBleGNoYW5nZSAtPm9wcyB3aXRoIG9uZSB0aGF0IGhhcyBvbmx5 IGEKPiByZWxlYXNlIGZ1bmN0aW9uLiBXZSBkb24ndCBuZWVkIGFueXRoaW5nIGVsc2UgYXMgbG9u ZyBhcyBhbGwgZmVuY2VfKgo+IGZ1bmN0aW9ucyB0aGUga2VybmVsIG1pZ2h0IGNhbGwgY2hlY2sg Zm9yIHNpZ25hbGxpbmcgY29ycmVjdGx5IGZpcnN0Cj4gKGZlbmNlX3dhaXQgaXMgYnJva2VuIGF0 IGxlYXN0KS4KPiAKPiBPciB3ZSBqdXN0IGdpdmUgdXAgKGZvciBub3cpIGFuZCBkZWNsYXJlIG1v ZHVsZSB1bmxvYWQgYXMgc2xpZ2h0bHkgcmFjeS4KPiBkbWEtYnVmIGlzIHNpbWlsYXIuIEFuIGlu dGVybWVkaWF0ZSBvcHRpb24gbWlnaHQgYmUgdG8gYXQgbGVhc3QgYWRkIGEKPiBUSElTX01PRFVM RSByZWZlcmVuY2UgdG8gZWFjaCBmZW5jZSAoYnV0IHRoYXQncyBhIGJpdCBleHBlbnNpdmUgLi4u KS4KCkknZCBzYXkgd2UganVzdCBnaXZlIHVwIGZvciBub3cgYXMgd2UgZG9uJ3QgaGF2ZSBhbnkg ZHJpdmVyIHVzaW5nCnRpbWVsaW5lX2Rlc3Ryb3kgZm9yIG5vdy4gU28gd2UgY291bGQgZ28gZm9y IG90aGVyIGltcHJvdmVtZW50cyBmaXJzdC4KCj4gLSBiYWNrIHRvIHRpbWVsaW5lIHZzLiBjb250 ZXh0OiBJIGhhdmUgbm8gaWRlYSBob3cgdG8gYmVzdCBjbGVhbiB1cCB0aGlzCj4gICBtZXNzLCBi dXQgbGVhc3QgcGFpbmZ1bCBvcHRpb24gbG9uZy10ZXJtIGlzIHByb2JhYmx5IHRvIHN3aXRjaCBv dmVyIGFsbAo+ICAgY3VycmVudCB1c2VycyBvZiBmZW5jZV9jb250ZXh0X2FsbG9jIHRvIHRpbWVs aW5lcyBhbmQgcmVtb3ZlIHRoZSBwbGFpbgo+ICAgY29udGV4dCBpbnRlcmZhY2UuCgpBZ3JlZWQu Cgo+IAo+IC0gSW1vIHRoZSBpbnRlcmZhY2UgaW4gaW5jbHVkZS9saW51eC9zeW5jLmggaXMgZHVw bGljYXRpbmcgdG9vIG11Y2ggb2YKPiAgIGZlbmNlLmguIEkgdGhpbmsgdGhlIG9ubHkgYml0cyB3 ZSBuZWVkIGFyZSB0aGUgcmVmY291bnRpbmcsIGNyZWF0aW5nLAo+ICAgZmQtaW5zdGFsbCBhbmQg dGhhdCdzIGl0LiBQbHVzIGEgbWFjcm8gdG8gbG9vcCBvdmVyIGFsbCB0aGUgZmVuY2VzIGluIGEK PiAgIHN5bmNfZmVuY2UuIFdpdGggdGhhdCBkcml2ZXJzIHdpbGwgb25seSBldmVyIGRlYWwgd2l0 aCBhIHBpbGUgb2YKPiAgIHN0cnVjdCBmZW5jZSwgbWFraW5nIGltcGxpY2l0IGZlbmNpbmcgKHVz aW5nIHRoZSBmZW5jZSBsaXN0IGluIGRtYS1idWYpCj4gICBhbmQgZXhwbGljaXQgZmVuY2luZyAo dXNpbmcgdGhlIGZlbmNlIGxpc3QgaW4gc3luY19mZW5jZSkgbXVjaCBtb3JlCj4gICBzaW1pbGFy LgoKWWVzLCBtb3N0IG9mIHRoZSBzeW5jX2ZlbmNlIHdhaXRpbmcgc2hvdWxkIG5vdCBiZSBleHBv cnRlZC4gRHJpdmVycwpzaG91bGQgb25seSB3YWl0IGZvciBmZW5jZSBpbW8sIG5vdCBzeW5jX2Zl bmNlcy4KCj4gCj4gICBBbmQgd2UgY2FuIGVhc2lseSBkbyB0aGF0IHNpbmNlIG5vIGludGVybmFs IHVzZXJzIDstKQo+IAo+IC0gZ2V0X3RpbWVsaW5lX25hbWUgYW5kIGdldF9kcml2ZXJfbmFtZSBh cmUgaW1vIHRvbyBtdWNoIGluZGlyZWN0aW9uLCBqdXN0Cj4gICBhZGQgLT4oZHJ2XyluYW1lIGZp ZWxkIHRvIGVhY2ggb2YgdGhlc2UuCj4gCj4gLSBzdHJ1Y3Qgc3luY19mZW5jZSBpcyBhIG1ham9y IGNvbmZ1c2lvbiBpbW8gYWdhaW5zdCBzdHJ1Y3QgZmVuY2UuIEl0Cj4gICBtYWRlIG11Y2ggbW9y ZSBzZW5zZSBpbiB0aGUgcHVyZS1hbmRyb2lkIHdvcmxkIHdoZXJlIGZlbmNlID09IHN5bmNfcHQu Cj4gICBNYXliZSB3ZSBjYW4gcmVuYW1lIHN5bmNfZmVuY2UgdG8gc3luY19mZW5jZV9mZCAoYSBi aXQgbG9uZywgYW5kIGZkIGlzIGEKPiAgIGJpdCBpbmFjY3VyYXRlKSwgc3luY19maWxlIChsaWtl IHRoaXMgYmVzdCksIGZlbmNlX2ZpbGUgKHNvdW5kcyBzaWxseQo+ICAgaW1vKSwgb3Igc29tZXRo aW5nIGVsc2U/CgpzeW5jX2ZpbGUgc291bmRzIGdvb2QgZm9yIG1lLiBmZW5jZV9maWxlIGZlZWxz IGxpa2UgaXQgYSBmaWxlIGZvciBhCnNpbmdsZSBmZW5jZSBidXQgd2UgbWF5IGhhdmUgbWFueSBm ZW5jZXMgb24gb25lIHN5bmNfZmlsZS4KCj4gCj4gLSBJIGd1ZXNzIGp1c3Qgbm90IHlldCBwYXJ0 IG9mIHRoaXMgcmZjLCBidXQgbW92aW5nIHRoZSB0ZXN0c3VpdGUgYW5kCj4gICBhZGRpbmcga2Vy bmVsZG9jIGZvciB0aGlzIGlzIHBsYW5uZWQgSSBndWVzcz8gSWYgeW91IGZlZWwgbGlrZSBJIHRo aW5rCj4gICBpdCdkIGJlIGJlc3QuIFdlIHB1bGwgdGhlIGN1cnJlbnQgZG1hLWJ1ZiBzdHVmZiBp bnRvCj4gICBkZXZpY2UtZHJpdmVycy50bXBsLCBidXQgaXQncyBjb21wbGV0ZWx5IGxhY2tpbmcg b3ZlcnZpZXcgZG9jcyBhbmQgYWxsCj4gICB0aGF0LiBBbmQgSSdkIGxpa2UgdG8gZHVwbGljYXRl IGF0IGxlYXN0IHRoZSBkbWEtYnVmL2ZlbmNlIHNlY3Rpb25zIGludG8KPiAgIHRoZSBncHUudG1w bCBkb2Nib29rLgoKV2UgaGF2ZSBjb252ZXJ0ZWQgdGVzdHN1aXRlIGZyb20gYW5kcm9pZCdzIGxp YnN5bmMgYnV0IHdlIG5lZWQgdG8gd2FpdApmb3IgR29vZ2xlIHRvIHJlLWxpY2Vuc2UgaXQgdG8g c2VuZCBpdCB1cHN0cmVhbS4KCmtlcm5lbGRvYyBpcyBwbGFubmVkIGZvciBzdXJlLCBidXQgSSdk IHNheSBpdCB3aWxsIGJlIGJldHRlciB0byBoYXZlCnNvbWUgdXNlcnMgZmlyc3QsIERSTSBmb3Ig ZXhhbXBsZS4KCj4gCj4gLSBJZiB3ZSBtYWtlIHRpbWVsaW5lcyBmaXJzdCBjbGFzcyBvYmplY3Rz IEkgdGhpbmsgd2UgY291bGQgbW92ZSBzb21lIG9mCj4gICB0aGUgZmllbGRzIGZyb20gc3RydWN0 IGZlbmNlIHRvIHN0cnVjdCBmZW5jZV90aW1lbGluZS4gRS5nLiB0aGUgb3BzCj4gICBzdHJ1Y3Qu IFRoYXQgYWxzbyBtYWtlcyBpdCBjbGVhcmVyIHRoYXQgc29tZSBvZiB0aGUgdmZ1bmNzIHJlYWxs eSBzaG91bGQKPiAgIGJlIHRha2luZyBhIHN0cnVjdCBmZW5jZV90aW1lbGluZSAqdGltZWxpbmUg aW5zdGVhZCBvZiBhIHN0cnVjdCBmZW5jZQo+ICAgKmZlbmNlIGFzIHRoZWlyIHByaW1hcnkgcGFy YW1ldGVyLgoKSSdsbCBrZWVwIHRoYXQgYXMgYSBmaW5hbCBnb2FsIGFuZCB3b3JrIFJGQyB2MiBh bmQgc2VlIGhvdyBmYXIgd2UgY2FuCmdldC4KCglHdXN0YXZvCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756224AbcASPXU (ORCPT ); Tue, 19 Jan 2016 10:23:20 -0500 Received: from mail-yk0-f173.google.com ([209.85.160.173]:32910 "EHLO mail-yk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754297AbcASPXN (ORCPT ); Tue, 19 Jan 2016 10:23:13 -0500 Date: Tue, 19 Jan 2016 13:23:09 -0200 From: Gustavo Padovan To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan Subject: Re: [RFC 00/29] De-stage android's sync framework Message-ID: <20160119152309.GA8217@joana> Mail-Followup-To: Gustavo Padovan , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> <20160119110017.GZ19130@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160119110017.GZ19130@phenom.ffwll.local> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, 2016-01-19 Daniel Vetter : > On Fri, Jan 15, 2016 at 12:55:10PM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > This patch series de-stage the sync framework, and in order to accomplish that > > a bunch of cleanups/improvements on the sync and fence were made. > > > > The sync framework contained some abstractions around struct fence and those > > were removed in the de-staging process among other changes: > > > > Userspace visible changes > > ------------------------- > > > > * The sw_sync file was moved from /dev/sw_sync to /sync/sw_sync. No > > other change. > > > > Kernel API changes > > ------------------ > > > > * struct sync_timeline is now struct fence_timeline > > * sync_timeline_ops is now fence_timeline_ops and they now carry struct > > fence as parameter instead of struct sync_pt > > * a .cleanup() fence op was added to allow sync_fence to run a cleanup when > > the fence_timeline is destroyed > > * added fence_add_used_data() to pass a private point to struct fence. This > > pointer is sent back on the .cleanup op. > > * The sync timeline function were moved to be fence_timeline functions: > > - sync_timeline_create() -> fence_timeline_create() > > - sync_timeline_get() -> fence_timeline_get() > > - sync_timeline_put() -> fence_timeline_put() > > - sync_timeline_destroy() -> fence_timeline_destroy() > > - sync_timeline_signal() -> fence_timeline_signal() > > > > * sync_pt_create() was replaced be fence_create_on_timeline() > > > > Internal changes > > ---------------- > > > > * fence_timeline_ops was removed in favor of direct use fence_ops > > * fence default functions were created for fence_ops > > * removed structs sync_pt, sw_sync_timeline and sw_sync_pt > > Bunch of fairly random comments all over: > > - include/uapi/linux/sw_sync.h imo should be dropped, it's just a private > debugfs interface between fence fds and the testsuite. Since the plan is > to have the testcases integrated into the kernel tree too we don't need > a public header. > > - similar for include/linux/sw_sync.h Imo that should all be moved into > sync_debug.c. Same for sw_sync.c, that should all land in sync_debug > imo, and made optional with a Kconfig option. At least we should reuse > CONFIG_DEBUGFS. These two items sounds reasonable to me. > > - fence_context and fence_timeline are really the same. timeline has some > super-basic support for doing sw-only fence timelines, but imo that's > not really worth keeping (and if so better to keep seperate in a > sw-fence.c or similar, like seqno-fence.c). The other main thing > timeline provides is support to clean up fences on a timeline. And imo > that cleanup should be done by the core fence support, not by the add-on > stuff. Yes, they are. But I currently doesn't know how to merge them best, so I decided to go for a RFC instead of trying some crazy solution touching all fence_context users. > > Interlude about fence cleanup on driver unload: > > Working drivers imo should never call timeline_destroy when there's still > an unsignalled fence around for that timeline/context. That just means > they're broken and failed to clean up all the pending work. So the problem > really is only what to do with fences where the driver disappeared, and > for that we essentially need a fence_revoke() function (which could be > called internally from timeline_free). So here's what I think > timeline_free should do: > > for_each_fence_on_timel() { > WARN_ON(!fence_is_signalled()); > > fence_revoke(fence); > } > > Implementing fence_revoke is a bit tricky since we need to make sure the > memory contained ->ops and similar stuff doesn't disappear. Simplest > option might be to grab a temporary reference (using > kref_get_unless_zero), and then exchange ->ops with one that has only a > release function. We don't need anything else as long as all fence_* > functions the kernel might call check for signalling correctly first > (fence_wait is broken at least). > > Or we just give up (for now) and declare module unload as slightly racy. > dma-buf is similar. An intermediate option might be to at least add a > THIS_MODULE reference to each fence (but that's a bit expensive ...). I'd say we just give up for now as we don't have any driver using timeline_destroy for now. So we could go for other improvements first. > - back to timeline vs. context: I have no idea how to best clean up this > mess, but least painful option long-term is probably to switch over all > current users of fence_context_alloc to timelines and remove the plain > context interface. Agreed. > > - Imo the interface in include/linux/sync.h is duplicating too much of > fence.h. I think the only bits we need are the refcounting, creating, > fd-install and that's it. Plus a macro to loop over all the fences in a > sync_fence. With that drivers will only ever deal with a pile of > struct fence, making implicit fencing (using the fence list in dma-buf) > and explicit fencing (using the fence list in sync_fence) much more > similar. Yes, most of the sync_fence waiting should not be exported. Drivers should only wait for fence imo, not sync_fences. > > And we can easily do that since no internal users ;-) > > - get_timeline_name and get_driver_name are imo too much indirection, just > add ->(drv_)name field to each of these. > > - struct sync_fence is a major confusion imo against struct fence. It > made much more sense in the pure-android world where fence == sync_pt. > Maybe we can rename sync_fence to sync_fence_fd (a bit long, and fd is a > bit inaccurate), sync_file (like this best), fence_file (sounds silly > imo), or something else? sync_file sounds good for me. fence_file feels like it a file for a single fence but we may have many fences on one sync_file. > > - I guess just not yet part of this rfc, but moving the testsuite and > adding kerneldoc for this is planned I guess? If you feel like I think > it'd be best. We pull the current dma-buf stuff into > device-drivers.tmpl, but it's completely lacking overview docs and all > that. And I'd like to duplicate at least the dma-buf/fence sections into > the gpu.tmpl docbook. We have converted testsuite from android's libsync but we need to wait for Google to re-license it to send it upstream. kerneldoc is planned for sure, but I'd say it will be better to have some users first, DRM for example. > > - If we make timelines first class objects I think we could move some of > the fields from struct fence to struct fence_timeline. E.g. the ops > struct. That also makes it clearer that some of the vfuncs really should > be taking a struct fence_timeline *timeline instead of a struct fence > *fence as their primary parameter. I'll keep that as a final goal and work RFC v2 and see how far we can get. Gustavo