All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shaohua Li <shli@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Neil Brown <neilb@suse.com>, linux-raid@vger.kernel.org
Subject: Re: [PATCH] Abort pending request for RAID10
Date: Tue, 19 Jan 2016 10:53:42 -0800	[thread overview]
Message-ID: <20160119185342.GA8149@kernel.org> (raw)
In-Reply-To: <1453193726-4617-1-git-send-email-hare@suse.de>

On Tue, Jan 19, 2016 at 09:55:26AM +0100, Hannes Reinecke wrote:
> RAID10 delays the write until the bitmap has been updated.
> So it really should check if the device is still working
> before sending requests, otherwise it'll happily sending
> I/O to a known faulty device.

Hi,

__make_request already checks the faulty bit. That's possible the disk becomes
faulty after __make_request check though. But faulty bit can be set any time,
for example, after the check with your patch. There is no guarantee pending
writes get canceled immediately after the disk is marked faulty. I'm wondering
what's the real problem.

Thanks,
Shaohua

      parent reply	other threads:[~2016-01-19 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19  8:55 [PATCH] Abort pending request for RAID10 Hannes Reinecke
2016-01-19  9:05 ` kbuild test robot
2016-01-19 18:53 ` Shaohua Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160119185342.GA8149@kernel.org \
    --to=shli@kernel.org \
    --cc=hare@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.