From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Do not put big intel_crtc_state on the stack Date: Tue, 19 Jan 2016 21:22:17 +0100 Message-ID: <20160119202217.GT19130@phenom.ffwll.local> References: <1453217117-26125-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 707766E0A3 for ; Tue, 19 Jan 2016 12:22:13 -0800 (PST) Received: by mail-wm0-f54.google.com with SMTP id l65so153626308wmf.1 for ; Tue, 19 Jan 2016 12:22:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <1453217117-26125-1-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Daniel Vetter , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMTksIDIwMTYgYXQgMDM6MjU6MTdQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBIYXZpbmcgdGhpcyBvbiBzdGFjayB0cmlnZ2VycyB0aGUgLVdmcmFtZS1sYXJnZXItdGhh bj0xMDI0IGFuZAo+IGlzIG5vdCBuaWNlIHRvIHB1dCBzdWNoIGJpZyB0aGluZ3Mgb24gdGhlIGtl cm5lbCBzdGFjayBhbnl3YXkuCj4gCj4gVGhpcyByZXF1aXJlZCBhIGxpdHRsZSBiaXQgb2YgcmVm YWN0b3JpbmcgdG8gaGFuZGxlIHRoZSBuZXcKPiBmYWlsdXJlIHBhdGggZnJvbSB2bHZfZm9yY2Vf cGxsX29uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxp bkBpbnRlbC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+ Cj4gQ2M6IEpvaG4gSGFycmlzb24gPGpvaG4uYy5oYXJyaXNvbkBpbnRlbC5jb20+Cj4gQ2M6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gQ29t cGlsZSB0ZXN0ZWQgb25seSEKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIHwgNTggKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICAgICB8ICA4ICsrKy0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICA0ICstLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDQ1 IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPiBpbmRleCBjY2IzZTNmNDc0NTAuLjdiZjE4NjU4YzY1OSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtNzYzNSwyNiArNzYzNSwzNCBAQCBz dGF0aWMgdm9pZCBjaHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gICAq IGluIGNhc2VzIHdoZXJlIHdlIG5lZWQgdGhlIFBMTCBlbmFibGVkIGV2ZW4gd2hlbiBAcGlwZSBp cyBub3QgZ29pbmcgdG8KPiAgICogYmUgZW5hYmxlZC4KPiAgICovCj4gLXZvaWQgdmx2X2ZvcmNl X3BsbF9vbihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBlbnVtIHBpcGUgcGlwZSwKPiAraW50IHZs dl9mb3JjZV9wbGxfb24oc3RydWN0IGRybV9kZXZpY2UgKmRldiwgZW51bSBwaXBlIHBpcGUsCj4g IAkJICAgICAgY29uc3Qgc3RydWN0IGRwbGwgKmRwbGwpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9j cnRjICpjcnRjID0KPiAgCQl0b19pbnRlbF9jcnRjKGludGVsX2dldF9jcnRjX2Zvcl9waXBlKGRl diwgcGlwZSkpOwo+IC0Jc3RydWN0IGludGVsX2NydGNfc3RhdGUgcGlwZV9jb25maWcgPSB7Cj4g LQkJLmJhc2UuY3J0YyA9ICZjcnRjLT5iYXNlLAo+IC0JCS5waXhlbF9tdWx0aXBsaWVyID0gMSwK PiAtCQkuZHBsbCA9ICpkcGxsLAo+IC0JfTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpw aXBlX2NvbmZpZzsKPiArCj4gKwlwaXBlX2NvbmZpZyA9IGt6YWxsb2Moc2l6ZW9mKCpwaXBlX2Nv bmZpZyksIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFwaXBlX2NvbmZpZykKPiArCQlyZXR1cm4gLUVO T01FTTsKCnRiaCBJIHdvdWxkbid0IGJvdGhlciB3aXRoIHRoZSByZXR1cm4gY29kZSBoZXJlIHNp bmNlIHRoZSBvbmx5IGNhbGxlcgpjYW4ndCBkbyBhbnl0aGluZyBhYm91dCBpdCBhbnl3YXkuIEJ1 dCBzaW5jZSB0aGlzIGlzIGEgYml0IGEgYmlrZXNoZWQsCmVpdGhlciB3YXk6CgpSZXZpZXdlZC1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gKwo+ICsJcGlwZV9j b25maWctPmJhc2UuY3J0YyA9ICZjcnRjLT5iYXNlOwo+ICsJcGlwZV9jb25maWctPnBpeGVsX211 bHRpcGxpZXIgPSAxOwo+ICsJcGlwZV9jb25maWctPmRwbGwgPSAqZHBsbDsKPiAgCj4gIAlpZiAo SVNfQ0hFUlJZVklFVyhkZXYpKSB7Cj4gLQkJY2h2X2NvbXB1dGVfZHBsbChjcnRjLCAmcGlwZV9j b25maWcpOwo+IC0JCWNodl9wcmVwYXJlX3BsbChjcnRjLCAmcGlwZV9jb25maWcpOwo+IC0JCWNo dl9lbmFibGVfcGxsKGNydGMsICZwaXBlX2NvbmZpZyk7Cj4gKwkJY2h2X2NvbXB1dGVfZHBsbChj cnRjLCBwaXBlX2NvbmZpZyk7Cj4gKwkJY2h2X3ByZXBhcmVfcGxsKGNydGMsIHBpcGVfY29uZmln KTsKPiArCQljaHZfZW5hYmxlX3BsbChjcnRjLCBwaXBlX2NvbmZpZyk7Cj4gIAl9IGVsc2Ugewo+ IC0JCXZsdl9jb21wdXRlX2RwbGwoY3J0YywgJnBpcGVfY29uZmlnKTsKPiAtCQl2bHZfcHJlcGFy ZV9wbGwoY3J0YywgJnBpcGVfY29uZmlnKTsKPiAtCQl2bHZfZW5hYmxlX3BsbChjcnRjLCAmcGlw ZV9jb25maWcpOwo+ICsJCXZsdl9jb21wdXRlX2RwbGwoY3J0YywgcGlwZV9jb25maWcpOwo+ICsJ CXZsdl9wcmVwYXJlX3BsbChjcnRjLCBwaXBlX2NvbmZpZyk7Cj4gKwkJdmx2X2VuYWJsZV9wbGwo Y3J0YywgcGlwZV9jb25maWcpOwo+ICAJfQo+ICsKPiArCWtmcmVlKHBpcGVfY29uZmlnKTsKPiAr Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgLyoqCj4gQEAgLTEwODI4LDcgKzEwODM2LDcgQEAg c3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmludGVsX2NydGNfbW9kZV9nZXQoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxf Y3J0YyhjcnRjKTsKPiAgCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9IGludGVsX2Ny dGMtPmNvbmZpZy0+Y3B1X3RyYW5zY29kZXI7Cj4gIAlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAq bW9kZTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlIHBpcGVfY29uZmlnOwo+ICsJc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnOwo+ICAJaW50IGh0b3QgPSBJOTE1X1JFQUQo SFRPVEFMKGNwdV90cmFuc2NvZGVyKSk7Cj4gIAlpbnQgaHN5bmMgPSBJOTE1X1JFQUQoSFNZTkMo Y3B1X3RyYW5zY29kZXIpKTsKPiAgCWludCB2dG90ID0gSTkxNV9SRUFEKFZUT1RBTChjcHVfdHJh bnNjb2RlcikpOwo+IEBAIC0xMDgzOSw2ICsxMDg0NywxMiBAQCBzdHJ1Y3QgZHJtX2Rpc3BsYXlf bW9kZSAqaW50ZWxfY3J0Y19tb2RlX2dldChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJaWYg KCFtb2RlKQo+ICAJCXJldHVybiBOVUxMOwo+ICAKPiArCXBpcGVfY29uZmlnID0ga3phbGxvYyhz aXplb2YoKnBpcGVfY29uZmlnKSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIXBpcGVfY29uZmlnKSB7 Cj4gKwkJa2ZyZWUobW9kZSk7Cj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwl9Cj4gKwo+ICAJLyoKPiAg CSAqIENvbnN0cnVjdCBhIHBpcGVfY29uZmlnIHN1ZmZpY2llbnQgZm9yIGdldHRpbmcgdGhlIGNs b2NrIGluZm8KPiAgCSAqIGJhY2sgb3V0IG9mIGNydGNfY2xvY2tfZ2V0Lgo+IEBAIC0xMDg0Niwx NCArMTA4NjAsMTQgQEAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmludGVsX2NydGNfbW9kZV9n ZXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCSAqIE5vdGUsIGlmIExWRFMgZXZlciB1c2Vz IGEgbm9uLTEgcGl4ZWwgbXVsdGlwbGllciwgd2UnbGwgbmVlZAo+ICAJICogdG8gdXNlIGEgcmVh bCB2YWx1ZSBoZXJlIGluc3RlYWQuCj4gIAkgKi8KPiAtCXBpcGVfY29uZmlnLmNwdV90cmFuc2Nv ZGVyID0gKGVudW0gdHJhbnNjb2RlcikgcGlwZTsKPiAtCXBpcGVfY29uZmlnLnBpeGVsX211bHRp cGxpZXIgPSAxOwo+IC0JcGlwZV9jb25maWcuZHBsbF9od19zdGF0ZS5kcGxsID0gSTkxNV9SRUFE KERQTEwocGlwZSkpOwo+IC0JcGlwZV9jb25maWcuZHBsbF9od19zdGF0ZS5mcDAgPSBJOTE1X1JF QUQoRlAwKHBpcGUpKTsKPiAtCXBpcGVfY29uZmlnLmRwbGxfaHdfc3RhdGUuZnAxID0gSTkxNV9S RUFEKEZQMShwaXBlKSk7Cj4gLQlpOXh4X2NydGNfY2xvY2tfZ2V0KGludGVsX2NydGMsICZwaXBl X2NvbmZpZyk7Cj4gLQo+IC0JbW9kZS0+Y2xvY2sgPSBwaXBlX2NvbmZpZy5wb3J0X2Nsb2NrIC8g cGlwZV9jb25maWcucGl4ZWxfbXVsdGlwbGllcjsKPiArCXBpcGVfY29uZmlnLT5jcHVfdHJhbnNj b2RlciA9IChlbnVtIHRyYW5zY29kZXIpIHBpcGU7Cj4gKwlwaXBlX2NvbmZpZy0+cGl4ZWxfbXVs dGlwbGllciA9IDE7Cj4gKwlwaXBlX2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5kcGxsID0gSTkxNV9S RUFEKERQTEwocGlwZSkpOwo+ICsJcGlwZV9jb25maWctPmRwbGxfaHdfc3RhdGUuZnAwID0gSTkx NV9SRUFEKEZQMChwaXBlKSk7Cj4gKwlwaXBlX2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5mcDEgPSBJ OTE1X1JFQUQoRlAxKHBpcGUpKTsKPiArCWk5eHhfY3J0Y19jbG9ja19nZXQoaW50ZWxfY3J0Yywg cGlwZV9jb25maWcpOwo+ICsKPiArCW1vZGUtPmNsb2NrID0gcGlwZV9jb25maWctPnBvcnRfY2xv Y2sgLyBwaXBlX2NvbmZpZy0+cGl4ZWxfbXVsdGlwbGllcjsKPiAgCW1vZGUtPmhkaXNwbGF5ID0g KGh0b3QgJiAweGZmZmYpICsgMTsKPiAgCW1vZGUtPmh0b3RhbCA9ICgoaHRvdCAmIDB4ZmZmZjAw MDApID4+IDE2KSArIDE7Cj4gIAltb2RlLT5oc3luY19zdGFydCA9IChoc3luYyAmIDB4ZmZmZikg KyAxOwo+IEBAIC0xMDg2NSw2ICsxMDg3OSw4IEBAIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpp bnRlbF9jcnRjX21vZGVfZ2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAo+ICAJZHJtX21v ZGVfc2V0X25hbWUobW9kZSk7Cj4gIAo+ICsJa2ZyZWUocGlwZV9jb25maWcpOwo+ICsKPiAgCXJl dHVybiBtb2RlOwo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDE3NjEy NTQ4YzU4ZC4uZTJiZWE3MTA2MTRmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAg LTMzNSw4ICszMzUsMTIgQEAgdmx2X3Bvd2VyX3NlcXVlbmNlcl9raWNrKHN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHApCj4gIAkJcmVsZWFzZV9jbF9vdmVycmlkZSA9IElTX0NIRVJSWVZJRVcoZGV2 KSAmJgo+ICAJCQkhY2h2X3BoeV9wb3dlcmdhdGVfY2goZGV2X3ByaXYsIHBoeSwgY2gsIHRydWUp Owo+ICAKPiAtCQl2bHZfZm9yY2VfcGxsX29uKGRldiwgcGlwZSwgSVNfQ0hFUlJZVklFVyhkZXYp ID8KPiAtCQkJCSAmY2h2X2RwbGxbMF0uZHBsbCA6ICZ2bHZfZHBsbFswXS5kcGxsKTsKPiArCQlp ZiAodmx2X2ZvcmNlX3BsbF9vbihkZXYsIHBpcGUsIElTX0NIRVJSWVZJRVcoZGV2KSA/Cj4gKwkJ CQkgICAgICZjaHZfZHBsbFswXS5kcGxsIDogJnZsdl9kcGxsWzBdLmRwbGwpKSB7Cj4gKwkJCURS TV9FUlJPUigiRmFpbGVkIHRvIGZvcmNlIG9uIHBsbCBmb3IgcGlwZSAlYyFcbiIsCj4gKwkJCQkg IHBpcGVfbmFtZShwaXBlKSk7Cj4gKwkJCXJldHVybjsKPiArCQl9Cj4gIAl9Cj4gIAo+ICAJLyoK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDA1OWI0NmUyMmMzMS4uNTM4ZmFhZjRl ZWVmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTE3Nyw4ICsxMTc3LDgg QEAgdm9pZCBhc3NlcnRfc2hhcmVkX2RwbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKmludGVsX2dldF9zaGFyZWRfZHBsbChz dHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCQkJCQkJc3RydWN0IGludGVsX2NydGNfc3RhdGUg KnN0YXRlKTsKPiAgCj4gLXZvaWQgdmx2X2ZvcmNlX3BsbF9vbihzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LCBlbnVtIHBpcGUgcGlwZSwKPiAtCQkgICAgICBjb25zdCBzdHJ1Y3QgZHBsbCAqZHBsbCk7 Cj4gK2ludCB2bHZfZm9yY2VfcGxsX29uKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGVudW0gcGlw ZSBwaXBlLAo+ICsJCSAgICAgY29uc3Qgc3RydWN0IGRwbGwgKmRwbGwpOwo+ICB2b2lkIHZsdl9m b3JjZV9wbGxfb2ZmKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGVudW0gcGlwZSBwaXBlKTsKPiAg Cj4gIC8qIG1vZGVzZXR0aW5nIGFzc2VydHMgKi8KPiAtLSAKPiAxLjkuMQo+IAoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==