From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC 00/29] De-stage android's sync framework Date: Tue, 19 Jan 2016 21:32:03 +0100 Message-ID: <20160119203203.GV19130@phenom.ffwll.local> References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> <20160119110017.GZ19130@phenom.ffwll.local> <20160119201040.GD8217@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC7506E87C for ; Tue, 19 Jan 2016 12:31:59 -0800 (PST) Received: by mail-wm0-f54.google.com with SMTP id u188so159113958wmu.1 for ; Tue, 19 Jan 2016 12:31:59 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160119201040.GD8217@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMTksIDIwMTYgYXQgMDY6MTA6NDBQTSAtMDIwMCwgR3VzdGF2byBQYWRvdmFu IHdyb3RlOgo+IDIwMTYtMDEtMTkgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPjoKPiA+ IC0gZ2V0X3RpbWVsaW5lX25hbWUgYW5kIGdldF9kcml2ZXJfbmFtZSBhcmUgaW1vIHRvbyBtdWNo IGluZGlyZWN0aW9uLCBqdXN0Cj4gPiAgIGFkZCAtPihkcnZfKW5hbWUgZmllbGQgdG8gZWFjaCBv ZiB0aGVzZS4KPiAKPiBJIGRvbid0IHRoaW5rIGlzIGEgZ29vZCBpZGVhIHRvIGNoYW5nZSB0aGF0 IG5vdyBhcyB0aGVyZSBhcmUgb3RoZXIgZmVuY2UKPiB1c2VycyBpbiB0aGUga2VybmVsIHVzaW5n IGdldF90aW1lbGluZV9uYW1lIGFuZCBnZXRfZHJpdmVyX25hbWUuIFdoYXQgSQo+IHByb3Bvc2Ug aXMgdHJ5IGdldCByaWQgb2YgdGhpcyB3aGVuIG1vdmluZyBvcHMgZnJvbSBmZW5jZXMgdG8KPiBm ZW5jZV90aW1lbGluZS4KCk1ha2VzIHNlbnNlLiBBbmQgeWVhaCBJIG9ubHkgcmVhbGl6ZWQgYWZ0 ZXIgc2VuZGluZyB0aGF0IHRoaXMgd2Fzbid0IGFkZGVkCmJ5IHlvdXIgcGF0Y2hlcywganVzdCB0 aGF0IHlvdXIgcGF0Y2hlcyBhZGRlZCB0aGUgKGNvcmUpIHVzZXJzIGZvciBpdC4KLURhbmllbAot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933280AbcASUcO (ORCPT ); Tue, 19 Jan 2016 15:32:14 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:34338 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933184AbcASUb7 (ORCPT ); Tue, 19 Jan 2016 15:31:59 -0500 Date: Tue, 19 Jan 2016 21:32:03 +0100 From: Daniel Vetter To: Gustavo Padovan , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan Subject: Re: [RFC 00/29] De-stage android's sync framework Message-ID: <20160119203203.GV19130@phenom.ffwll.local> Mail-Followup-To: Gustavo Padovan , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> <20160119110017.GZ19130@phenom.ffwll.local> <20160119201040.GD8217@joana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160119201040.GD8217@joana> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2016 at 06:10:40PM -0200, Gustavo Padovan wrote: > 2016-01-19 Daniel Vetter : > > - get_timeline_name and get_driver_name are imo too much indirection, just > > add ->(drv_)name field to each of these. > > I don't think is a good idea to change that now as there are other fence > users in the kernel using get_timeline_name and get_driver_name. What I > propose is try get rid of this when moving ops from fences to > fence_timeline. Makes sense. And yeah I only realized after sending that this wasn't added by your patches, just that your patches added the (core) users for it. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch