From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757931AbcASVdW (ORCPT ); Tue, 19 Jan 2016 16:33:22 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:50556 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757872AbcASVdC (ORCPT ); Tue, 19 Jan 2016 16:33:02 -0500 Date: Tue, 19 Jan 2016 21:32:57 +0000 From: Ben Hutchings To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org Message-ID: <20160119213256.GD2637@decadent.org.uk> References: <20160119213213.GB2637@decadent.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tMbDGjvJuJijemkf" Content-Disposition: inline In-Reply-To: <20160119213213.GB2637@decadent.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ben@decadent.org.uk Subject: [PATCH perf 2/4] perf top: Fix behaviour of Shift-Tab in annotated view with nothing focussed X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on shadbolt.decadent.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tMbDGjvJuJijemkf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline gcc 6 catches a case of missing braces: ui/browsers/annotate.c: In function 'annotate_browser__run': ui/browsers/annotate.c:760:5: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] if (nd == NULL) ^~ ui/browsers/annotate.c:758:4: note: ...this 'if' clause, but it is not if (nd != NULL) ^~ Fixes: c97cf42219b7 ("perf top: Live TUI Annotation") Signed-off-by: Ben Hutchings --- tools/perf/ui/browsers/annotate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index d4d7cc2..718bd46 100644 --- a/tools/perf/ui/browsers/annotate.c +++ b/tools/perf/ui/browsers/annotate.c @@ -755,11 +755,11 @@ static int annotate_browser__run(struct annotate_browser *browser, nd = browser->curr_hot; break; case K_UNTAB: - if (nd != NULL) + if (nd != NULL) { nd = rb_next(nd); if (nd == NULL) nd = rb_first(&browser->entries); - else + } else nd = browser->curr_hot; break; case K_F1: --tMbDGjvJuJijemkf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUBVp6riOe/yOyVhhEJAQo9lBAAnXvQj5jJcs08ojEhvgqIM0Hwu3hj1W3c Y1o4oQXdhenshwnIO9o3Rf9ELmbnQq7MM0ta2osN3BSOchhcF7MYbWVAat//2ldd uQKgUxShgutmz8KIIr688nGL2vnUPyepiRjd/Q5rrh268gxHm6/jdYWkcn+NdMAT 38PpicjmAjjdUJX75lkoXCPkxRla02b7mw1Y39/5J0/TfbOe4Fxh1wQtyzOsmMJs tVI6m1kDmZ6QVL2YB7LgK0uW+98mPz3sK+vJ1aFmbJIjgI5ede0F3NSFqV1YT9nk +dacHWlhyCdQY0lXeeK674eya01wCaD5lJTU3XFjS6n9VuJPxeApryhXohmfhBHP Zh2SpRbCV3p53i5pbwkdkh7zQXC4Wc3OIX/0uFDuKNfg6JUIhTzLKGN1J13RNBaS PusvAjC5Lk76YTyDntVreIevsRh9szj8C/PnYo9pVcLgBJr1dIm6Hv6xuwcMSvlr 6AKjzXZmZhPDsirlsp8YJF51InC6PFHDk2orG/rkz61VLNecorqOgPAaHuCNooqh 2bayWG7kU1SWrV+yzozKg5QVSCO2t+Kd2bMZJsZkEAvdPAW97gbnPP2Hu3gti2YX J4TBPizTX0Tx1Rp0JACtBviIJdfKxgbPijyGYXuCQ2pt76wMomWkUwtUtKvyNX10 uIdNCUxibn4= =NkpL -----END PGP SIGNATURE----- --tMbDGjvJuJijemkf--