From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLiZz-0006W4-05 for qemu-devel@nongnu.org; Tue, 19 Jan 2016 21:33:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLiZx-00032B-Rd for qemu-devel@nongnu.org; Tue, 19 Jan 2016 21:33:02 -0500 Date: Wed, 20 Jan 2016 12:57:34 +1100 From: David Gibson Message-ID: <20160120015734.GF27454@voom.redhat.com> References: <1453174759-22837-1-git-send-email-david@gibson.dropbear.id.au> <1453174759-22837-9-git-send-email-david@gibson.dropbear.id.au> <87bn8idnd8.fsf@blackfin.pond.sub.org> <20160119082504.GD27454@voom.redhat.com> <87si1tep4h.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lIrNkN/7tmsD/ALM" Content-Disposition: inline In-Reply-To: <87si1tep4h.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: lvivier@redhat.com, thuth@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org --lIrNkN/7tmsD/ALM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 19, 2016 at 01:21:34PM +0100, Markus Armbruster wrote: > David Gibson writes: >=20 > > On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: > >> David Gibson writes: > >>=20 > >> > The functions for migrating the hash page table on pseries machine t= ype > >> > (htab_save_setup() and htab_load()) can report some errors with an > >> > explicit fprintf() before returning an appropriate error code. Chan= ge these > >> > to use error_report() instead. > >> > > >> > Signed-off-by: David Gibson > >> > Reviewed-by: Thomas Huth > >> > --- > >> > hw/ppc/spapr.c | 12 ++++++------ > >> > 1 file changed, 6 insertions(+), 6 deletions(-) > >> > > >> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > >> > index 3cfacb9..1eb7d03 100644 > >> > --- a/hw/ppc/spapr.c > >> > +++ b/hw/ppc/spapr.c > >>=20 > >> Lost this hunk: > >>=20 > >> @@ -1309,8 +1309,9 @@ static int htab_save_setup(QEMUFile *f, void *= opaque) > >> spapr->htab_fd =3D kvmppc_get_htab_fd(false); > >> spapr->htab_fd_stale =3D false; > >> if (spapr->htab_fd < 0) { > >> - fprintf(stderr, "Unable to open fd for reading hash tab= le from KVM: %s\n", > >> - strerror(errno)); > >> + error_report( > >> + "Unable to open fd for reading hash table from KVM:= %s", > >> + strerror(errno)); > >> return -1; > >> } > >> } > >>=20 > >> Intentional? > > > > Yes. As noted in the cover letter, this conflicts with another series > > I'm working on, which will obsolete this change anyway. >=20 > The patch doesn't quite hold what the commit message's promises, but I > guess that's okay. An "except for htab_save_setup()" in the commit > message wouldn't hurt, though. Ok. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --lIrNkN/7tmsD/ALM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWnumOAAoJEGw4ysog2bOS50EP/3im1mKiJatQC5ozcfv/n+8c sHfwyd+kz9ioIN0Cqd/1gnc7eKXiiWaB3YPaJlR2eASyGK1CntGuN85cmPrVPD1B hNbbKaAIyrTgfCp4/VlXw3LaKI/EDjyB6f17vARN079hkVTXT1zPUoo75Puoyl35 WqpFnzrSUQ4mm2EKuN7I6w3p/OBMba/VIC/HF0I6brclA0QgcjhcDcVxwSs+gBCe rxk43F2/Bq/ytpHtiWzXNZh4Q91nitHfRBGOWCu/9Iwe4a0Xet78/ZR4YGRVR2KH 7TBNbfbrVdLw16JC8rhD3sEXrtcLeULTDDOco8Sn1F27E1yoSWj6d/aJeqU6lL/3 y5xCGfl63MSJ7zmbD5S5FTUlsHuFJO0w3m8kTKOIl9ylcMgwyoBtvFjCWK7nbiGJ 1ijGDAjbLprvLWSsCw2DA73mnb96i8DXExblsphEHVIFmScLjRz64ONUi7G9M1aC 5w0ue1iUAU7B+XMmN4bnQSeBP3Uh+tcg2TX/6wcAv6Ocgl9Qg7WYh5hHbYlF1btL wVlgt6rGwtdmS5xNJbW/Sidn/P2x6g5WrT2RVQ5uKXAIiUxSQkLHIBKFSWdCT5EC iO1HGrfihKqN2zzE8OtTtZwRSfrnsLJ5VuXSHBF+S5yMlbEv58ijZk0OIfNRVsrf /sevZ5inL/0izL+lIpgB =t/VM -----END PGP SIGNATURE----- --lIrNkN/7tmsD/ALM--