From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: expose link status and speed using
 xstats
Date: Wed, 20 Jan 2016 10:36:04 -0800
Message-ID: <20160120103604.2e32c9ac@xeon-e3>
References: <1453300086-3756-1-git-send-email-harry.van.haaren@intel.com>
 <E923DB57A917B54B9182A2E928D00FA61285F3A6@IRSMSX102.ger.corp.intel.com>
 <CAMFWN9kjhU7njoOEht8beZbxBWBshh44tsFvnD0HnbkVeh2MqQ@mail.gmail.com>
 <3240763.FVKPEEMrPZ@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id EB74C8DAF
 for <dev@dpdk.org>; Wed, 20 Jan 2016 19:35:56 +0100 (CET)
Received: by mail-pf0-f179.google.com with SMTP id e65so8826987pfe.0
 for <dev@dpdk.org>; Wed, 20 Jan 2016 10:35:56 -0800 (PST)
In-Reply-To: <3240763.FVKPEEMrPZ@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 20 Jan 2016 16:13:34 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> > We already have the rte_eth_link_get function. Why not let users
> > continue to use that? It's well defined, it is simple, and it is
> > consistent.  

+1

API's should not duplicate results (DRY)

That said, it would be useful to have some way to get statistics
on the number of link transitions and time since last change.
But this ideally should be in rte_eth_link_get() but that wouldn't
be ABI compatiable.