From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.dk>
Cc: pfeiffer.szilard@balabit.hu, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH conntrack 1/2] Revert "conntrack: fix expectation entry creation"
Date: Wed, 20 Jan 2016 15:09:55 +0100 [thread overview]
Message-ID: <20160120140955.GA441@salvia> (raw)
In-Reply-To: <1452887264-26064-1-git-send-email-ast@fiberby.dk>
On Fri, Jan 15, 2016 at 07:47:43PM +0000, Asbjørn Sloth Tønnesen wrote:
> {} is mask-src and mask-dst, [] is tuple-src and tuple-dst
> mask-* should be stored in mask, tuple-* should be stored in exptuple.
Applied, thanks for fixing up this.
BTW, we have better tests under:
conntrack-tools/tests/conntrack/testsuite
I remember you also posted patches for:
http://patchwork.ozlabs.org/patch/428341/
http://patchwork.ozlabs.org/patch/428343/
http://patchwork.ozlabs.org/patch/428342/
It would be great if you can follow up on this, IIRC the only changed
I asked for is that it would be good to have test for this new
feature.
This has been in my TODO list for a while and I didn't find the time
to make it myself.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-20 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 19:47 [PATCH conntrack 1/2] Revert "conntrack: fix expectation entry creation" Asbjørn Sloth Tønnesen
2016-01-15 19:47 ` [PATCH conntrack 2/2] conntrack: fix expectation entry creation Asbjørn Sloth Tønnesen
2016-01-20 14:10 ` Pablo Neira Ayuso
2016-01-20 14:09 ` Pablo Neira Ayuso [this message]
2016-01-20 20:30 ` [PATCH conntrack 1/2] Revert "conntrack: fix expectation entry creation" Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120140955.GA441@salvia \
--to=pablo@netfilter.org \
--cc=ast@fiberby.dk \
--cc=netfilter-devel@vger.kernel.org \
--cc=pfeiffer.szilard@balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.