From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v10 4/4] toolchain-external: create symlink ARCH_LIB_DIR->lib
Date: Wed, 20 Jan 2016 16:24:34 +0100 [thread overview]
Message-ID: <20160120162434.5ac86865@free-electrons.com> (raw)
In-Reply-To: <1453302547-24314-4-git-send-email-patrickdepinguin@gmail.com>
Dear Thomas De Schampheleire,
On Wed, 20 Jan 2016 16:09:07 +0100, Thomas De Schampheleire wrote:
> + ARCH_LIB_DIR="$(call toolchain_find_libdir,$(TOOLCHAIN_EXTERNAL_CC) $(TOOLCHAIN_EXTERNAL_CFLAGS))" ; \
> + if [ "$${ARCH_LIB_DIR}" != "lib" -a "$${ARCH_LIB_DIR}" != "$(SKELETON_LIB_SYMLINK)" ]; then \
Where is SKELETON_LIB_SYMLINK defined? Shouldn't this be
TOOLCHAIN_LIB_SYMLINK ?
Or better, can we indeed name the variable SKELETON_LIB_SYMLINK, have
it under skeleton.mk, and replace this test by something that simply
tests if ARCH_LIB_DIR exists or not. If it exists (i.e it's the lib/
directory, or one of the lib32/ or lib64/ symlinks), there is nothing
to do, otherwise you need to create the symlinks.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-20 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 15:09 [Buildroot] [PATCH v10 1/4] Makefile: move LIB_SYMLINK definition to toolchain/helpers.mk Thomas De Schampheleire
2016-01-20 15:09 ` [Buildroot] [PATCH v10 2/4] toolchain-external: don't exclude too much lib in sysroot rsync Thomas De Schampheleire
2016-01-20 15:09 ` [Buildroot] [PATCH v10 3/4] toolchain-external: improve sysroot rsync if ARCH_LIB_DIR != lib/lib32/lib64 Thomas De Schampheleire
2016-01-20 15:09 ` [Buildroot] [PATCH v10 4/4] toolchain-external: create symlink ARCH_LIB_DIR->lib Thomas De Schampheleire
2016-01-20 15:24 ` Thomas Petazzoni [this message]
2016-01-20 15:58 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120162434.5ac86865@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.