All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] defconfigs: use the new headers-version-same-as-kernel-version option
Date: Wed, 20 Jan 2016 22:58:21 +0100	[thread overview]
Message-ID: <20160120215821.GD3992@free.fr> (raw)
In-Reply-To: <20160120213824.686c94fb@free-electrons.com>

Thomas, All,

On 2016-01-20 21:38 +0100, Thomas Petazzoni spake thusly:
> On Wed, 20 Jan 2016 19:34:29 +0100, Yann E. MORIN wrote:
> > Now that we can say that the linux headers version should match that of
> > the kernel to be built, we inverse the logic in our defconfigs, as it is
> > more sensible that way.
> > 
> > And also because we'll get rid of the former, converse kernel-same-as-headers
> > option.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> In this commit, you are changing the defconfigs that use
> BR2_LINUX_KERNEL_SAME_AS_HEADERS. But I am wondering if we shouldn't
> simply change *all* defconfigs to use this new feature. Essentially all
> defconfigs have to worry about selecting a kernel headers version that
> matches the kernel version they use. We could switch them all to use
> your new mechanism, no?

Well, I think it may be worse than that, in fact... Let's see what
happens with a trivial defconfig from before this patch, with the
default toolchain and the kernel settings:

    BR2_LINUX_KERNEL=y

This would give:

    BR2_KERNEL_HEADERS_4_4=y
    BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_4=y
    BR2_TOOLCHAIN_HEADERS_AT_LEAST="4.4"
    BR2_LINUX_KERNEL=y
    BR2_LINUX_KERNEL_LATEST_VERSION=y

Now we use that defconfig after this patch, this gives:

    BR2_KERNEL_HEADERS_AS_KERNEL=y
    BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_REALLY_OLD=y
    BR2_LINUX_KERNEL=y
    BR2_LINUX_KERNEL_VERSION="4.4"

And boom, we've lost BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_4=y

I have no idea how we could solve this. I doubt we want to add anything
like BR2_LINUX_KERNEL_AT_LEAST_4_4 and the likes... :-/

Ideas?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2016-01-20 21:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 18:34 [Buildroot] [PATCH 0/3] toolchain: add possibility to use kernel version for linux-headers (branch yem/kenrel-headers) Yann E. MORIN
2016-01-20 18:34 ` [Buildroot] [PATCH 1/3] package/linux-headers: add option to use same sources as the kernel Yann E. MORIN
2016-01-20 20:36   ` Thomas Petazzoni
2016-01-20 21:03     ` Yann E. MORIN
2016-02-02  9:05   ` Peter Korsgaard
2016-01-20 18:34 ` [Buildroot] [PATCH 2/3] defconfigs: use the new headers-version-same-as-kernel-version option Yann E. MORIN
2016-01-20 20:38   ` Thomas Petazzoni
2016-01-20 21:29     ` Peter Korsgaard
2016-01-20 21:37       ` Steve Calfee
2016-01-20 22:05         ` Thomas Petazzoni
2016-01-20 22:08         ` Yann E. MORIN
2016-01-20 21:58     ` Yann E. MORIN [this message]
2016-01-20 22:07       ` Thomas Petazzoni
2016-01-20 22:15         ` Yann E. MORIN
2016-01-20 18:34 ` [Buildroot] [PATCH 3/3] linux: drop the option to use the same version as that of the headers Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160120215821.GD3992@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.