From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM4BM-0004Dg-N3 for qemu-devel@nongnu.org; Wed, 20 Jan 2016 20:37:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aM4BL-0002Hy-10 for qemu-devel@nongnu.org; Wed, 20 Jan 2016 20:37:04 -0500 Date: Thu, 21 Jan 2016 12:13:46 +1100 From: David Gibson Message-ID: <20160121011346.GJ27454@voom.redhat.com> References: <1453178361-24244-1-git-send-email-bharata@linux.vnet.ibm.com> <20160119050025.GB27454@voom.redhat.com> <20160120053039.GA18882@in.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sdJFN6SSISdF2ksn" Content-Disposition: inline In-Reply-To: <20160120053039.GA18882@in.ibm.com> Subject: Re: [Qemu-devel] [PATCH] spapr: Don't create ibm, dynamic-reconfiguration-memory w/o DR LMBs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: aik@ozlabs.ru, qemu-ppc@nongnu.org, qemu-devel@nongnu.org --sdJFN6SSISdF2ksn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 20, 2016 at 11:00:39AM +0530, Bharata B Rao wrote: > On Tue, Jan 19, 2016 at 04:00:25PM +1100, David Gibson wrote: > > On Tue, Jan 19, 2016 at 10:09:21AM +0530, Bharata B Rao wrote: > > > If guest doesn't have any dynamically reconfigurable (DR) logical mem= ory > > > blocks (LMB), then we shouldn't create ibm,dynamic-reconfiguration-me= mory > > > device tree node. > > >=20 > > > Signed-off-by: Bharata B Rao > > > --- > > > This applies against ppc-for-2.6 branch of David Gibson's tree. > >=20 > > Applied to ppc-for-2.6, thanks. >=20 > There is a slight change in memory nodes representation in DT after this = fix > that could result in the following behaviour before and after migration. >=20 > For a guest with -m 4G -numa node,nodeid=3D0,mem=3D2G -numa node,nodeid= =3D1,mem=3D2G, > the DT under /proc/device-tree changes like this: >=20 > Guest started with QEMU w/o this fix > ------------------------------------ > memory@0 > memory@80000000 > ibm,dynamic-reconfiguration-memory >=20 > Guest migrated to QEMU w/ this fix included > ------------------------------------------- > memory@0 > memory@80000000 > ibm,dynamic-reconfiguration-memory >=20 > After next reboot > ----------------- > memory@0 > memory@80000000 >=20 > I guess this is ok, but wanted to sound out this change explicitly. Yeah, I think that should be ok. Generally device tree changes won't break migration, because the guest (or SLOF) will have already grabbed the old device tree from the source qemu. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --sdJFN6SSISdF2ksn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWoDDKAAoJEGw4ysog2bOSeQEQANhm63yI3HRPzCJ8j0GW5Hup Lxu58C1Myy3ZNgoAHQzhlBDq8HcTIEd/c4ExeUCwryBM9o6+8umvNcpPjGeJF7Ar O28809Mnvamx5JJIhS1S+MYnJlsnrUlqlerwWuWgD5G7SkXediGTRN6Zge00DswQ sIsvPl/EorTfshzEv3P14L+H+bwZdj0iwf8XyBFzKj4I+mOVEz459I44wTPeLNDf HPz7wH6JfC4Oymr2b4vEg0buDjJAgFaQJ6aWLneRt0DDZGpR09YS0xeNRMjeoMth N5aRqexSaJJnd/qie4BHqRbYxdgLfUTHucnyzxy8ptSrPnTCa7SKwQW65ucRPigO 626bM/8Y0lxIr0CqX+2aggOCQF8T52mzt3LxZj4vHlxskrjfAbKUQP6Og3Z14CAZ 9Fd5eDy2ASuV2QahF7IiZYyxGRr7QmSUopD/btBlSINpvaLuzPj46cYMtd6sfTYr Lh3UGbmaD0gPxLfOKotRAn7DggDYOoh5RIGTpxZ05FWHBVj/1vXdjsmXnz6Ty6T9 4cVnObIBmNXZNMsetB1ts6F3nAv7G2d48trki2sJne633IaL4dOGMYthRVh361oq Cswg/MNSRe8jcdXqyFwRSrvitnTqzvwKNizjd1TsE+NXJ9t/Rvxx0D7wzSsq5PDM ke0dfS3lrhSt/8FOzMgW =NYDd -----END PGP SIGNATURE----- --sdJFN6SSISdF2ksn--