From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37493)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aM5Z4-0002bd-R6
	for qemu-devel@nongnu.org; Wed, 20 Jan 2016 22:05:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aM5Z3-0000UC-UL
	for qemu-devel@nongnu.org; Wed, 20 Jan 2016 22:05:38 -0500
Date: Thu, 21 Jan 2016 11:05:24 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160121030524.GA31960@ad.usersys.redhat.com>
References: <1453270306-16608-1-git-send-email-famz@redhat.com>
	<1453270306-16608-3-git-send-email-famz@redhat.com>
	<569FBC55.7020602@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <569FBC55.7020602@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 02/13] typedefs: Add BdrvDirtyBitmap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, jsnow@redhat.com

On Wed, 01/20 09:56, Eric Blake wrote:
> On 01/19/2016 11:11 PM, Fam Zheng wrote:
> > Following patches to refactor and move block dirty bitmap code could use
> > this.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  include/block/block.h   | 3 +--
> >  include/qemu/typedefs.h | 1 +
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/block/block.h b/include/block/block.h
> > index c96923d..483bfd3 100644
> > --- a/include/block/block.h
> > +++ b/include/block/block.h
> > @@ -8,6 +8,7 @@
> >  #include "block/accounting.h"
> >  #include "qapi/qmp/qobject.h"
> >  #include "qapi-types.h"
> > +#include "qemu/hbitmap.h"
> >  
> >  /* block.c */
> >  typedef struct BlockDriver BlockDriver;
> > @@ -472,8 +473,6 @@ void *qemu_try_blockalign(BlockDriverState *bs, size_t size);
> >  void *qemu_try_blockalign0(BlockDriverState *bs, size_t size);
> >  bool bdrv_qiov_is_aligned(BlockDriverState *bs, QEMUIOVector *qiov);
> >  
> > -struct HBitmapIter;
> 
> You didn't mention removing this forward declaration in the commit
> message, making it look like an accident.
> 

It was intended, so it's the commit message. But I'll split the "#include" and
"HBitmapIter" hunks into another patch.

Fam