From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758614AbcAUFMX (ORCPT ); Thu, 21 Jan 2016 00:12:23 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:33757 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757907AbcAUFL6 (ORCPT ); Thu, 21 Jan 2016 00:11:58 -0500 Date: Wed, 20 Jan 2016 22:10:56 -0700 From: =?utf-8?B?Ss61YW4=?= Sacren To: David Miller Cc: julia.lawall@lip6.fr, shuahkhan@gmail.com, bh74.an@samsung.com, ks.giri@samsung.com, vipul.pandya@samsung.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, shuahkh@osg.samsung.com Subject: Re: question about samsung/sxgbe/sxgbe_xpcs.c Message-ID: <20160121051056.GA4373@mail.gmail.com> References: <20160119.143628.432983847877790677.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160119.143628.432983847877790677.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Miller Date: Tue, 19 Jan 2016 14:36:28 -0500 > > From: Julia Lawall > Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET) [...] > > I just wondered. I was looking at dependencies between networking files. > > This one stands out because nothing is dependenton it, even the files it > > is compiled with, and it doesn't contain the usual functions, > > register_netdev, etc. > > Even with that explanation, this is a bogus situation. > > There are no in-tree callers of this code. It should be removed until there > are in-tree users. > > Nobody can figure out if the interface for this is done properly without seeing > the call sites and how they work. It is therefore impossible to review this > code and judge it's design. > > If someone doesn't send me a removal patch, I will remove this code myself. I have the patch ready. Do you want me to submit it now during the merge window or wait till net-next opens up again?