From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758819AbcAUFWo (ORCPT ); Thu, 21 Jan 2016 00:22:44 -0500 Received: from arcturus.aphlor.org ([188.246.204.175]:48896 "EHLO arcturus.aphlor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbcAUFWj (ORCPT ); Thu, 21 Jan 2016 00:22:39 -0500 Date: Thu, 21 Jan 2016 00:22:35 -0500 From: Dave Jones To: Linux Kernel Mailing List Cc: Michal Marek Subject: Re: tags: Unify emacs and exuberant rules Message-ID: <20160121052235.GA15623@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Linux Kernel Mailing List , Michal Marek References: <20160120182204.CA45E6612A4@gitolite.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160120182204.CA45E6612A4@gitolite.kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Score: -2.9 (--) X-Spam-Report: Spam detection software, running on the system "arcturus.aphlor.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Jan 20, 2016 at 06:22:04PM +0000, Linux Kernel wrote: > Web: https://git.kernel.org/torvalds/c/93209d65c1d38f86ffb3f61a1214130b581a9709 > Commit: 93209d65c1d38f86ffb3f61a1214130b581a9709 > Parent: a1ccdb63b5535dc3446b0a9efc6d97aca82c72ef > Refname: refs/heads/master > Author: Michal Marek > AuthorDate: Wed Oct 14 11:48:06 2015 +0200 > Committer: Michal Marek > CommitDate: Tue Jan 5 22:18:48 2016 +0100 > > tags: Unify emacs and exuberant rules > > The emacs rules were constantly lagging behind the exuberant ones. Use a > single set of rules for both, to make the script easier to maintain. > The language understood by both tools is basic regular expression with > some limitations, which are documented in a comment. To be able to store > the rules in an array and easily iterate over it, the script requires > bash now. In the exuberant case, the change fixes some false matches in > and also some too greedy matches in the arguments > of the DECLARE_*/DEFINE_* macros. In the emacs case, several previously > not working rules are matching now. Tested with these versions of the > tools: > > Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert > etags (GNU Emacs 24.5) > > Signed-off-by: Michal Marek [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2016 at 06:22:04PM +0000, Linux Kernel wrote: > Web: https://git.kernel.org/torvalds/c/93209d65c1d38f86ffb3f61a1214130b581a9709 > Commit: 93209d65c1d38f86ffb3f61a1214130b581a9709 > Parent: a1ccdb63b5535dc3446b0a9efc6d97aca82c72ef > Refname: refs/heads/master > Author: Michal Marek > AuthorDate: Wed Oct 14 11:48:06 2015 +0200 > Committer: Michal Marek > CommitDate: Tue Jan 5 22:18:48 2016 +0100 > > tags: Unify emacs and exuberant rules > > The emacs rules were constantly lagging behind the exuberant ones. Use a > single set of rules for both, to make the script easier to maintain. > The language understood by both tools is basic regular expression with > some limitations, which are documented in a comment. To be able to store > the rules in an array and easily iterate over it, the script requires > bash now. In the exuberant case, the change fixes some false matches in > and also some too greedy matches in the arguments > of the DECLARE_*/DEFINE_* macros. In the emacs case, several previously > not working rules are matching now. Tested with these versions of the > tools: > > Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert > etags (GNU Emacs 24.5) > > Signed-off-by: Michal Marek Since today, make tags got a lot more noisy for me on Debian unstable (exuberant-ctags 1:5.9~svn20110310-10) $ make tags GEN tags ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name pattern "\1" ctags: Warning: drivers/acpi/processor_idle.c:64: null expansion of name pattern "\1" ctags: Warning: kernel/locking/lockdep.c:153: null expansion of name pattern "\1" ctags: Warning: kernel/workqueue.c:307: null expansion of name pattern "\1" ctags: Warning: kernel/rcu/rcutorture.c:133: null expansion of name pattern "\1" ctags: Warning: kernel/rcu/rcutorture.c:135: null expansion of name pattern "\1" ctags: Warning: net/rds/page.c:45: null expansion of name pattern "\1" ctags: Warning: net/ipv6/syncookies.c:44: null expansion of name pattern "\1" ctags: Warning: net/ipv4/syncookies.c:53: null expansion of name pattern "\1" Looks like it's choking on DEFINE_PER_CPU definitions ? Dave