From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMDYp-0007NN-5N for qemu-devel@nongnu.org; Thu, 21 Jan 2016 06:37:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMDYk-0003XI-W8 for qemu-devel@nongnu.org; Thu, 21 Jan 2016 06:37:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMDYk-0003XE-Qg for qemu-devel@nongnu.org; Thu, 21 Jan 2016 06:37:50 -0500 Date: Thu, 21 Jan 2016 11:37:46 +0000 From: "Richard W.M. Jones" Message-ID: <20160121113746.GO1766@redhat.com> References: <1452735417-5461-1-git-send-email-lersek@redhat.com> <20160114100359.GU1766@redhat.com> <5697730D.1090006@zoho.com> <20160114102324.GV1766@redhat.com> <5697CE49.9090005@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5697CE49.9090005@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/4] set the OEM fields in the RSDT and the FADT from the SLIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Alex , Xiao Guangrong , "Michael S. Tsirkin" , Shannon Zhao , Michael Tokarev , qemu-devel@nongnu.org, Paolo Bonzini , Igor Mammedov On Thu, Jan 14, 2016 at 05:35:21PM +0100, Laszlo Ersek wrote: > On 01/14/16 11:23, Richard W.M. Jones wrote: > > On Thu, Jan 14, 2016 at 01:06:05PM +0300, Alex wrote: > >> Richard, I just posted HW test results to > >> https://bugzilla.redhat.com/show_bug.cgi?id=1248758. > >> Should I do it here instead? > > > > I saw that. Testing a virt-p2v conversion is a lot more involved. It > > would involve something like this: > > > > (1) Install Win7 on a UEFI-based physical machine, ensuring that Win7 > > is using UEFI to boot (not CSM or BIOS). > > > > (2) Install a recent Fedora on a second machine (second machine may be > > a VM). 'dnf install virt-v2v' on this machine. > > > > (3) Boot virt-p2v ISO (http://oirase.annexia.org/virt-p2v/) on the > > first physical machine. Perform a P2V conversion > > (http://libguestfs.org/virt-p2v.1.html). > > > > (4) Boot the converted Win7 VM on the target qemu. Reproduce the > > original bug. We have never had the original bug reported to us by > > any customer. > > > > (5) Patch qemu on the target. > > > > (6) Boot virt-p2v ISO again, and perform a second conversion. > > > > (7) Verify that the bug (step 4) has been fixed. > > Very good description, thank you. > > > While I was looking at Laszlo's patches just now, I realized that I > > have an AMD box that uses UEFI (actually - it uses CSM right now, but > > I think I can make it boot using pure UEFI). I'll have to swap some > > disks around but I may be able to try this out today or tomorrow if I > > can find a spare hard disk. > > That would be awesome, yes. Thanks! I'm afraid I gave up on this -- did give it my best. It turns out that the machine that I thought supported UEFI boot does not. I'll keep an eye out for such a machine and test this in future. All was not lost because I did discover a few bugs in virt-p2v along the way: https://github.com/libguestfs/libguestfs/commit/7e2f2b0b2410587b81fd42bf741e3a36a5e75f6f https://github.com/libguestfs/libguestfs/commit/c3ebc0a83761c552e6c19163b6d87044ae1ca635 https://github.com/libguestfs/libguestfs/commit/3f376fa5137d73df681cc5eaaa9b5e4206d57fce https://github.com/libguestfs/libguestfs/commit/d723b352f8c10fb5244f17889cf68e13dd85c037 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top