From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47880)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aMEuW-0003wx-6N
	for qemu-devel@nongnu.org; Thu, 21 Jan 2016 08:04:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aMEuQ-0007PV-Ab
	for qemu-devel@nongnu.org; Thu, 21 Jan 2016 08:04:24 -0500
Date: Thu, 21 Jan 2016 21:03:59 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160121130359.GA31882@ad.usersys.redhat.com>
References: <1453270306-16608-1-git-send-email-famz@redhat.com>
	<56A0B5E4.8070003@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56A0B5E4.8070003@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v2 00/13] Dirty bitmap changes for
 migration/persistence work
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, jsnow@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Thu, 01/21 13:41, Vladimir Sementsov-Ogievskiy wrote:
> An idea/question.
> 
> What about make some const dirty bitmap finctions really const?
> 
> bdrv_dirty_bitmap_name(BdrvDirtyBitmap *bitmap)   ->
> bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap)
> bdrv_dirty_bitmap_size(BdrvDirtyBitmap *bitmap)     ->
> bdrv_dirty_bitmap_size(const BdrvDirtyBitmap *bitmap)
> 
> etc..

That is fine. I think that is a good practice which is not always adopted.

Fam