From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v1 2/2] x86/efi: print size and base in binary units in efi_print_memmap Date: Thu, 21 Jan 2016 14:05:31 +0000 Message-ID: <20160121140531.GD2510@codeblueprint.co.uk> References: <1452604386-13673-1-git-send-email-andriy.shevchenko@linux.intel.com> <1452604386-13673-2-git-send-email-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko Cc: Andy Shevchenko , Robert Elliott , Andrew Morton , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-efi@vger.kernel.org On Tue, 19 Jan, at 09:32:26AM, Andy Shevchenko wrote: > On Tue, Jan 12, 2016 at 3:13 PM, Andy Shevchenko > wrote: > > From: Robert Elliott > > > > Print the base address for each range in decimal alongside the size. > > Use a "(size @ base)" format similar to the fake_memmap kernel parameter. > > > > Print the range and base in the best-fit B, KiB, MiB, etc. units rather than > > always MiB. This avoids rounding, which can be misleading. > > > > Use proper IEC binary units (KiB, MiB, etc.) rather than misuse SI > > decimal units (KB, MB, etc.). > > > > old: > > efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff) (16384MB) > > > > new: > > efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff] (16 GiB @ 34 GiB) > > > > Signed-off-by: Robert Elliott > > Signed-off-by: Andy Shevchenko > > Matt, seems another approach is not in favour, which means we rather > stick with this one. But see one comment below. Thanks Andy. I like the below patch (with the included space), but as I said when reviewing Robert's version, I'm really not in favour of the "@ address" portition of the string. Andy, could you submit a v2 with the space fix and without the @ bit? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759595AbcAUOFl (ORCPT ); Thu, 21 Jan 2016 09:05:41 -0500 Received: from mail-pf0-f180.google.com ([209.85.192.180]:33356 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759560AbcAUOFg (ORCPT ); Thu, 21 Jan 2016 09:05:36 -0500 Date: Thu, 21 Jan 2016 14:05:31 +0000 From: Matt Fleming To: Andy Shevchenko Cc: Andy Shevchenko , Robert Elliott , Andrew Morton , linux-efi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 2/2] x86/efi: print size and base in binary units in efi_print_memmap Message-ID: <20160121140531.GD2510@codeblueprint.co.uk> References: <1452604386-13673-1-git-send-email-andriy.shevchenko@linux.intel.com> <1452604386-13673-2-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jan, at 09:32:26AM, Andy Shevchenko wrote: > On Tue, Jan 12, 2016 at 3:13 PM, Andy Shevchenko > wrote: > > From: Robert Elliott > > > > Print the base address for each range in decimal alongside the size. > > Use a "(size @ base)" format similar to the fake_memmap kernel parameter. > > > > Print the range and base in the best-fit B, KiB, MiB, etc. units rather than > > always MiB. This avoids rounding, which can be misleading. > > > > Use proper IEC binary units (KiB, MiB, etc.) rather than misuse SI > > decimal units (KB, MB, etc.). > > > > old: > > efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff) (16384MB) > > > > new: > > efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff] (16 GiB @ 34 GiB) > > > > Signed-off-by: Robert Elliott > > Signed-off-by: Andy Shevchenko > > Matt, seems another approach is not in favour, which means we rather > stick with this one. But see one comment below. Thanks Andy. I like the below patch (with the included space), but as I said when reviewing Robert's version, I'm really not in favour of the "@ address" portition of the string. Andy, could you submit a v2 with the space fix and without the @ bit?