From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v4 4/6] drm/dsi: Check for used channels Date: Thu, 21 Jan 2016 17:11:01 +0100 Message-ID: <20160121161059.GD647@ulmo.nvidia.com> References: <1448884892-7731-1-git-send-email-architt@codeaurora.org> <1449751300-2841-1-git-send-email-architt@codeaurora.org> <1449751300-2841-5-git-send-email-architt@codeaurora.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bajzpZikUji1w+G9" Return-path: Received: from hqemgate16.nvidia.com ([216.228.121.65]:8592 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964802AbcAUQLK (ORCPT ); Thu, 21 Jan 2016 11:11:10 -0500 In-Reply-To: <1449751300-2841-5-git-send-email-architt@codeaurora.org> Content-Disposition: inline Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Archit Taneja Cc: dri-devel@lists.freedesktop.org, a.hajda@samsung.com, jani.nikula@linux.intel.com, linux-kernel@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, l.stach@pengutronix.de, robh@kernel.org, linux-arm-msm@vger.kernel.org --bajzpZikUji1w+G9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 10, 2015 at 06:11:38PM +0530, Archit Taneja wrote: > We don't check whether a previously registered mipi_dsi_device under the > same host shares the same virtual channel. >=20 > Before registering, check if any of the registered devices doesn't > already have the same virtual channel. >=20 > This wasn't crucial when all the devices under a host were populated via > DT. Now that we also support creating devices manually, we could end up > in a situation where a driver tries to create a device with a virtual > channel already taken by a device populated in DT. >=20 > Reviewed-by: Andrzej Hajda > Signed-off-by: Archit Taneja > --- > drivers/gpu/drm/drm_mipi_dsi.c | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) I don't think this is necessary. The device name will be composed of the host's name, a '.' and the virtual channel ID, and the device core will refuse to create two devices with the same name. Thierry --bajzpZikUji1w+G9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWoQMTAAoJEN0jrNd/PrOhpvQP/jc1zhQUn0nRs0OseXhIsK3T qNFieYgtZXSJhz4IQ5wnbgmaVvnCmpwqvVI4q8hunbx5jTNWN5mWPhxQPKq9ESb2 wcLrbvuVQVUdxiQaAV58NSPLjdfm/ikHmXiDKMoosPekvhoORjblDWq1tGTzbV2l JT5+fXKr9mZw2xUkMfg5LJxxkzAV8/8F+C6fRHhgHS0W2G4he5hTtJ4mNKOFL7u5 MS7rixavxHcDRRYsQCQBA2lhLMZp+3R2T8aB0nTIpPT/SB/Le/ne/5RhKYhSjjAl VfGcE1NP4kAC4cHqbeRylQ743SysMl53pj+9YVOODQimA4Mr8B/XDLFUMeE3nJv1 g1JN9GNmfZVEEkEBfdYMITiCr7TFnxNlrNKvQpzI3hjtLnPd/ZVqpDdEhbvYqZt9 h08WqZSXF54OFnd3FwvUcWpDF9qvEN8EEjfmQxrwYZOgMU9kBvGFQ/FQReLsog9B IOjlkgwRt1bMdiF4zLK78+xRyZqWDYK5GAeELVtjOJZmNA18WxIS2uEPpCd2TfJE ltX6aNLAvufUV/WkRYOEi5IqUHmol6KmQDG+6/S7yiwrDFDlzdt+fye7w5aHYpUb V4chTlzA6rhv3LEfRIxb6+KMQ/hEQ5uN0zRIUAWobE+jJPBN1doJcR7wqP/PZiS4 yIjK1gPKooeXa1HPcW3G =NhPY -----END PGP SIGNATURE----- --bajzpZikUji1w+G9-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965583AbcAUQLM (ORCPT ); Thu, 21 Jan 2016 11:11:12 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:8592 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964802AbcAUQLK (ORCPT ); Thu, 21 Jan 2016 11:11:10 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 21 Jan 2016 08:12:17 -0800 Date: Thu, 21 Jan 2016 17:11:01 +0100 From: Thierry Reding To: Archit Taneja CC: , , , , , , , , Subject: Re: [PATCH v4 4/6] drm/dsi: Check for used channels Message-ID: <20160121161059.GD647@ulmo.nvidia.com> References: <1448884892-7731-1-git-send-email-architt@codeaurora.org> <1449751300-2841-1-git-send-email-architt@codeaurora.org> <1449751300-2841-5-git-send-email-architt@codeaurora.org> MIME-Version: 1.0 In-Reply-To: <1449751300-2841-5-git-send-email-architt@codeaurora.org> X-NVConfidentiality: public User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.2.68.189] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL102.nvidia.com (10.26.138.15) Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bajzpZikUji1w+G9" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bajzpZikUji1w+G9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 10, 2015 at 06:11:38PM +0530, Archit Taneja wrote: > We don't check whether a previously registered mipi_dsi_device under the > same host shares the same virtual channel. >=20 > Before registering, check if any of the registered devices doesn't > already have the same virtual channel. >=20 > This wasn't crucial when all the devices under a host were populated via > DT. Now that we also support creating devices manually, we could end up > in a situation where a driver tries to create a device with a virtual > channel already taken by a device populated in DT. >=20 > Reviewed-by: Andrzej Hajda > Signed-off-by: Archit Taneja > --- > drivers/gpu/drm/drm_mipi_dsi.c | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) I don't think this is necessary. The device name will be composed of the host's name, a '.' and the virtual channel ID, and the device core will refuse to create two devices with the same name. Thierry --bajzpZikUji1w+G9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWoQMTAAoJEN0jrNd/PrOhpvQP/jc1zhQUn0nRs0OseXhIsK3T qNFieYgtZXSJhz4IQ5wnbgmaVvnCmpwqvVI4q8hunbx5jTNWN5mWPhxQPKq9ESb2 wcLrbvuVQVUdxiQaAV58NSPLjdfm/ikHmXiDKMoosPekvhoORjblDWq1tGTzbV2l JT5+fXKr9mZw2xUkMfg5LJxxkzAV8/8F+C6fRHhgHS0W2G4he5hTtJ4mNKOFL7u5 MS7rixavxHcDRRYsQCQBA2lhLMZp+3R2T8aB0nTIpPT/SB/Le/ne/5RhKYhSjjAl VfGcE1NP4kAC4cHqbeRylQ743SysMl53pj+9YVOODQimA4Mr8B/XDLFUMeE3nJv1 g1JN9GNmfZVEEkEBfdYMITiCr7TFnxNlrNKvQpzI3hjtLnPd/ZVqpDdEhbvYqZt9 h08WqZSXF54OFnd3FwvUcWpDF9qvEN8EEjfmQxrwYZOgMU9kBvGFQ/FQReLsog9B IOjlkgwRt1bMdiF4zLK78+xRyZqWDYK5GAeELVtjOJZmNA18WxIS2uEPpCd2TfJE ltX6aNLAvufUV/WkRYOEi5IqUHmol6KmQDG+6/S7yiwrDFDlzdt+fye7w5aHYpUb V4chTlzA6rhv3LEfRIxb6+KMQ/hEQ5uN0zRIUAWobE+jJPBN1doJcR7wqP/PZiS4 yIjK1gPKooeXa1HPcW3G =NhPY -----END PGP SIGNATURE----- --bajzpZikUji1w+G9--