From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH v4] dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake) Date: Thu, 21 Jan 2016 13:57:42 -0800 Message-ID: <20160121215742.GH1979@malice.jf.intel.com> References: <20160120194050.GL7192@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org To: Andy Lutomirski Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Andy Lutomirski , platform-driver-x86@vger.kernel.org, Mario Limonciello , Matthew Garrett , Linux ACPI , Jon Eyolfson List-Id: linux-acpi@vger.kernel.org On Wed, Jan 20, 2016 at 12:46:23PM -0800, Andy Lutomirski wrote: > On Wed, Jan 20, 2016 at 11:40 AM, Pali Roh=E1r = wrote: > > On Tuesday 19 January 2016 15:07:47 Andy Lutomirski wrote: > >> The XPS 13 9350 sends WMI keypress events that aren't enumerated i= n > >> the DMI table. Add a table listing them. To avoid breaking thing= s > >> that worked before, these un-enumerated hotkeys won't be used if t= he > >> DMI table maps them to something else. > >> > >> FWIW, it appears that the DMI table may be a legacy thing and we > >> might want to rethink how we handle events in general. As an > >> example, a whole lot of things map to KEY_PROG3 via the DMI table. > >> > >> So far, this doesn't send keypress events for any of the new > >> events. Depnding on whether we figure out exactly what needs to > >> happen to get the wireless button working in time for Linux 4.5, > >> we might want to temporarily handle it in dell-wmi. > >> > >> Signed-off-by: Andy Lutomirski > > > > Looks good, > > > > Reviewed-by: Pali Roh=E1r >=20 > Darren, if/when you apply this, can you fix up the last paragraph of > the commit message? >=20 > This doesn't send keypress events for any of the new > events, as no models appear to require it. >=20 > I wrote the old text before intel-hid landed. Planning on queueing for 4.6 as soon as this window closes, likely tomo= rrow. I want this to have some time in -next. Thanks! >=20 > --Andy >=20 --=20 Darren Hart Intel Open Source Technology Center