All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Karel Zak <kzak@redhat.com>
Cc: Stanislav Brabec <sbrabec@suse.cz>, util-linux@vger.kernel.org
Subject: Re: [PATCH] libmount: handle btrfs default subvolume mount
Date: Fri, 22 Jan 2016 09:42:45 +0100	[thread overview]
Message-ID: <20160122084245.GR4227@suse.cz> (raw)
In-Reply-To: <20160121154529.hpv3ycl2syptemp4@ws.net.home>

On Thu, Jan 21, 2016 at 04:45:29PM +0100, Karel Zak wrote:
> On Thu, Jan 21, 2016 at 04:37:13PM +0100, Karel Zak wrote:
> > > David also wrote btrfs_get_default_subvolume_path(), but then we found,
> > > that there is probably better to use subvolid and path saved in
> > > procinfo:
> > 
> > Do you mean /proc/self/mountinfo ?
> > 
> > > 
> > > + The tab.c patch would be much smaller and straightforward.
> > > - Kernel evaluates it when creating procinfo entries, this would
> > >   duplicate it.
> > > x Both subvol and subvolid in procinfo were introduced together in the
> > >   mainline kernel, and btrfs_get_default_subvolume_path() needs more
> > >   ioctl() calls.
> > 
> > No sure if I follow.
> 
> Read it and the patch again, and now it makes sense. Yes, the ioctl and 
> subvolid= from mountinfo seems better than dependence on libbtrfs.

Also because util-linux is a build dependency for btrfs-progs.

  parent reply	other threads:[~2016-01-22  8:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 20:34 [PATCH] libmount: handle btrfs default subvolume mount Stanislav Brabec
2016-01-20 21:51 ` Stanislav Brabec
2016-01-20 21:57   ` Stanislav Brabec
2016-01-21  9:48     ` Karel Zak
2016-01-21 15:24       ` Stanislav Brabec
2016-01-21 15:37         ` Karel Zak
2016-01-21 15:45           ` Karel Zak
2016-01-21 17:24             ` Stanislav Brabec
2016-01-22  8:42             ` David Sterba [this message]
2016-01-21 21:58       ` Stanislav Brabec
2016-01-26 10:15         ` Karel Zak
2016-01-28 14:22         ` Stanislav Brabec
2016-02-01 12:18           ` Karel Zak
2016-02-01 15:38             ` Stanislav Brabec
2016-02-02 10:11               ` Karel Zak
2016-02-02 15:04                 ` Stanislav Brabec
2016-02-02 18:43                   ` Karel Zak
2016-02-02 19:36                     ` Stanislav Brabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160122084245.GR4227@suse.cz \
    --to=dsterba@suse.cz \
    --cc=kzak@redhat.com \
    --cc=sbrabec@suse.cz \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.