From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMYdR-0005Tq-Cb for qemu-devel@nongnu.org; Fri, 22 Jan 2016 05:08:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMYdN-0001dy-Lx for qemu-devel@nongnu.org; Fri, 22 Jan 2016 05:08:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMYdN-0001dt-Fh for qemu-devel@nongnu.org; Fri, 22 Jan 2016 05:08:01 -0500 Date: Fri, 22 Jan 2016 10:07:57 +0000 From: "Daniel P. Berrange" Message-ID: <20160122100756.GD14825@redhat.com> References: <1453451811-11860-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1453451811-11860-1-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: jasowang@redhat.com, qemu-devel@nongnu.org, zhangchen.fnst@cn.fujitsu.com, hongyang.yang@easystack.cn On Fri, Jan 22, 2016 at 04:36:44PM +0800, zhanghailiang wrote: > This series is a prerequisite for COLO, here we add each netdev > a default buffer filter, it is disabled by default, and has > no side effect for delivering packets in net layer. Why can't whatever is launching QEMU just setup filters explicitly if they want to use COLO ? I'm not seeing an obvious compelling reason to add this by default and then add extra code to deal with special casing its behaviour. > > Besides, patch 1 fixes the ouput information of 'info network' command > for filter. > > zhanghailiang (7): > net/filter: Fix the output information for command 'info network' > net/filter: Add a 'status' property for filter object > net/filter: Skip the disabled filter when delivering packets > net/filter: Introduce a helper to add a filter to the netdev > filter-buffer: Accept zero interval > net/filter: Add a default filter to each netdev > net/filter: prevent the default filter to be deleted > > include/net/filter.h | 25 +++++++- > net/dump.c | 2 - > net/filter-buffer.c | 10 ---- > net/filter.c | 163 +++++++++++++++++++++++++++++++++++++++++++++------ > net/net.c | 27 ++++++++- > 5 files changed, 194 insertions(+), 33 deletions(-) Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|