All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Michal Malý" <madcatxster@devoid-pointer.net>
Cc: "Bjørn Mork" <bjorn@mork.no>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmitry.torokhov@gmail.com, jikos@kernel.org, elias.vds@gmail.com,
	edwin@velds.nl, simon@mungewell.org
Subject: Re: [PATCH 0/2] Add a skeleton module to perform a basic initialization on certain USB devices
Date: Sat, 23 Jan 2016 08:39:34 -0800	[thread overview]
Message-ID: <20160123163934.GA3526@kroah.com> (raw)
In-Reply-To: <6032606.IBdJ88hxWq@the-raza>

On Sat, Jan 23, 2016 at 04:56:27PM +0100, Michal Malý wrote:
> On sobota 23. ledna 2016 13:46:32 CET Bjørn Mork wrote:
> > Michal Malý <madcatxster@devoid-pointer.net> writes:
> > > This mini series adds a simple skeleton module whose only purpose is to
> > > bring devices that at first appear as a generic USB device into another
> > > mode that can be handled by a more specific subsystem.
> > > 
> > > This patch was originally requested by Dmitry, reasoning that loading the
> > > entire xpad module just to switch a Logitech G920 wheel into HID mode is
> > > excessive and does not make much sense.
> > > 
> > > The module can be extended to handle any other USB device that might
> > > require such a switch.
> > 
> > Can this switching be done in userspace? That's what we normally do, ref
> > usb_modeswitch.
> 
> I briefly considered leaving the switch up to the userspace and handling the 
> device in the kernel only once it's been switched. I am however uncertain how 
> to advertise this to the users. Writing a tiny app that would currently handle 
> just one device seems like an overkill,

Writing a kernel driver that can be done in userspace is also overkill :)

> abusing usb_modeswitch seems counter-
> intuitive as it's purpose is to handle various USB modems. Having a tiny 
> module in the kernel looks like the most straightforward thing to do as far as 
> user experience is concerned.
> 
> I would not object to deferring the switch to userspace as long as there is an 
> easy way how to communicate the need for a small switching tool to the users.

Have your program install a udev rule to make it run automatically when
the device is plugged in, and then just file a bug with the different
distros to have them pick up your program and add it to their releases.
With free services like Github to host the code, and OBS to build
packages for every different distro out there, there has never been an
easier time to get programs to distros.

So please just do this in userspace, we don't like to take kernel
drivers for functions that can be done in userspace.

thanks,

greg k-h

  reply	other threads:[~2016-01-23 16:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-23 10:35 [PATCH 0/2] Add a skeleton module to perform a basic initialization on certain USB devices Michal Malý
2016-01-23 10:35 ` [PATCH 1/2] Add usb_skelswitch skeleton module to do basic initialization of devices that at first appear as a generic USB device Michal Malý
2016-01-23 10:35 ` [PATCH 2/2] Use usb_skelswitch module to switch Logitech G920 Racing Wheel to HID mode Michal Malý
2016-01-23 12:46 ` [PATCH 0/2] Add a skeleton module to perform a basic initialization on certain USB devices Bjørn Mork
2016-01-23 15:56   ` Michal Malý
2016-01-23 16:39     ` Greg KH [this message]
2016-01-24 22:05       ` Oliver Neukum
2016-01-24 22:48         ` Greg KH
2016-01-25 11:27           ` Oliver Neukum
2016-01-25 14:17     ` Jiri Kosina
2016-01-25 21:02       ` Michal Malý

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160123163934.GA3526@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bjorn@mork.no \
    --cc=dmitry.torokhov@gmail.com \
    --cc=edwin@velds.nl \
    --cc=elias.vds@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=madcatxster@devoid-pointer.net \
    --cc=simon@mungewell.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.