From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752546AbcAWXvw (ORCPT ); Sat, 23 Jan 2016 18:51:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54812 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbcAWXvs (ORCPT ); Sat, 23 Jan 2016 18:51:48 -0500 Date: Sat, 23 Jan 2016 15:51:47 -0800 From: Greg KH To: Insu Yun Cc: jslaby@suse.com, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu Subject: Re: [PATCH] vt: correctly check return value of class_create Message-ID: <20160123235147.GC32511@kroah.com> References: <1453582366-23407-1-git-send-email-wuninsu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453582366-23407-1-git-send-email-wuninsu@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 23, 2016 at 03:52:46PM -0500, Insu Yun wrote: > Since class_create can be failed in memory pressure, In this case, really? At init time? > its return value should be checked and correctly handled. You didn't correctly handle it, you leaked memory and other resources :(