From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755186AbcAYCQh (ORCPT ); Sun, 24 Jan 2016 21:16:37 -0500 Received: from one.firstfloor.org ([193.170.194.197]:53628 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754807AbcAYCQe (ORCPT ); Sun, 24 Jan 2016 21:16:34 -0500 Date: Mon, 25 Jan 2016 03:16:31 +0100 From: Andi Kleen To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen , David Ahern , Frederic Weisbecker , Wang Nan Subject: Re: [PATCHSET 00/12] perf tools: Apply percent-limit to callchains Message-ID: <20160125021631.GF31686@two.firstfloor.org> References: <1453643615-1616-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453643615-1616-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 24, 2016 at 10:53:23PM +0900, Namhyung Kim wrote: > Hello, > > This patchset tries to implement percent limit to callchains which was > requested by Andi Kleen. For some reason, limiting callchains by > (overhead) percentage didn't work well. This patch fixes it and make > --percent-limit also works for callchains as well as hist entries. > > This is available on 'perf/callchain-limit-v1' branch in my tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git > > Any comments are welcome, Thanks! Looks good to me. -Andi