From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [mtd-utils PATCH] mkfs.ubifs: <sys/xattr.h>, not <attr/xattr.h>
Date: Sun, 24 Jan 2016 20:13:13 -0800 [thread overview]
Message-ID: <20160125041313.GA9817@localhost> (raw)
In-Reply-To: <56A3F437.5080507@nod.at>
On Sat, Jan 23, 2016 at 10:44:23PM +0100, Richard Weinberger wrote:
> Am 23.01.2016 um 22:31 schrieb Brian Norris:
> > To be consistent with mkfs.jffs2, and to get this to build on my
> > machine, it looks like we should use <sys/xattr.h>, not <attr/xattr.h>.
> >
> > Fixes this error, seen on an Ubuntu 14.04 build system:
> >
> > ubifs-utils/mkfs.ubifs/mkfs.ubifs.c:30:24: fatal error: attr/xattr.h: No such file or directory
> > #include <attr/xattr.h>
>
> The build fails because you don't have libattr-devel (or however your distro names that package).
> Switching to sys/xattr.h from glibc-devel seems fine to me as mkfs.ubifs.c is using only basic xattr stuff.
Ah, thanks for the clarification.
> Reviewed-by: Richard Weinberger <richard@nod.at>
Pushed to mtd-utils.git.
Brian
prev parent reply other threads:[~2016-01-25 4:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 21:31 [mtd-utils PATCH] mkfs.ubifs: <sys/xattr.h>, not <attr/xattr.h> Brian Norris
2016-01-23 21:44 ` Richard Weinberger
2016-01-25 4:13 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125041313.GA9817@localhost \
--to=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mkl@pengutronix.de \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.