From: Alexander Duyck <aduyck@mirantis.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH v3 00/15] TSO and checksum fixes for i40e
Date: Sun, 24 Jan 2016 21:16:05 -0800 [thread overview]
Message-ID: <20160125050602.12004.38884.stgit@localhost.localdomain> (raw)
This patch set is meant to improve the performance and reliability of i40e
when it comes to performing TSO and Tx checksum offloads related to
tunnels.
I have tested it with a number of combinations of v4 over v6 and v6 over v4
for VXLANs. With GRE I have only been able to test with v4 as the base as
it appears that offloads are currently not supported for GRE over IPv6.
With this patch set I resolved a number of issues and I am now able to
perform TSO for any of them as long as the outer UDP checksum is 0. It
should also now be supported if the outer checksum is enabled in the case
of the XL722, though I cannot test it.
One additional item I have identified as an issue for the v2 patchset is
the fact that Rx checksums were not working for IPv6 based tunnels due to
the fact that the ports were not being registered. From what I can tell
there was no reason for this so I have enabled IPv6 tunnels to register
their port numbers so that they can take full advantage of Rx offloads.
v2: Expanded coverage to include i40evf
Enabled IPv6 tunnel support for Rx
Moved XL722 support from generic checksum to TSO
v3: Fixed comments to match code in checksum path
Dropped unused flag for checksum
Dropped protocol parameter since it was unused in ATR function
Testing Hints:
I would recommend setting up a series of tunnels between two endpoints.
For VXLAN both v4 and v6 based tunnels can be used, with and without
checksums. For GRE a v4 tunnel can be used with and without checksum.
Significant performance improvements should be seen for IPv6 based tunnels,
or IPv4 tunnels passing IPv6 traffic with netperf.
The XL722 should no longer insert checksums for tunnels that do not have
udpcsum set. This can be verified via tcpdump on the link partner. XL722
should show significant performance improvements for transmit with tunnels
that have udpcsum with netperf TCP_STREAM testing.
The i40evf driver will show significant Tx performance improvements for
tunnels. This can be verified with netperf.
---
Alexander Duyck (15):
i40e/i40evf: Drop outer checksum offload that was not requested
i40e/i40evf: Use u64 values instead of casting them in TSO function
i40e/i40evf: Factor out L4 header and checksum from L3 bits in TSO path
i40e/i40evf: Consolidate all header changes into TSO function
i40e/i40evf: Replace header pointers with unions of pointers in Tx checksum path
i40e/i40evf: Add support for IPv4 encapsulated in IPv6
i40e/i40evf: Handle IPv6 extension headers in checksum offload
i40e/i40evf: Do not write to descriptor unless we complete
i40e/i40evf: Add exception handling for Tx checksum
i40e/i40evf: Clean-up Rx packet checksum handling
i40e/i40evf: Enable support for SKB_GSO_UDP_TUNNEL_CSUM
i40e: Fix ATR in relation to tunnels
i40e: Do not drop support for IPv6 VXLAN or GENEVE tunnels
i40e: Update feature flags to reflect newly enabled features
i40evf: Update feature flags to reflect newly enabled features
drivers/net/ethernet/intel/i40e/i40e_main.c | 30 +-
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 385 ++++++++++++-----------
drivers/net/ethernet/intel/i40e/i40e_txrx.h | 2
drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 360 ++++++++++++----------
drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 2
drivers/net/ethernet/intel/i40evf/i40evf_main.c | 23 +
6 files changed, 424 insertions(+), 378 deletions(-)
--
next reply other threads:[~2016-01-25 5:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 5:16 Alexander Duyck [this message]
2016-01-25 5:16 ` [Intel-wired-lan] [next PATCH v3 01/15] i40e/i40evf: Drop outer checksum offload that was not requested Alexander Duyck
2016-01-27 16:00 ` Bowers, AndrewX
2016-01-25 5:16 ` [Intel-wired-lan] [next PATCH v3 02/15] i40e/i40evf: Use u64 values instead of casting them in TSO function Alexander Duyck
2016-01-27 16:03 ` Bowers, AndrewX
2016-01-25 5:16 ` [Intel-wired-lan] [next PATCH v3 03/15] i40e/i40evf: Factor out L4 header and checksum from L3 bits in TSO path Alexander Duyck
2016-01-27 16:09 ` Bowers, AndrewX
2016-01-25 5:16 ` [Intel-wired-lan] [next PATCH v3 04/15] i40e/i40evf: Consolidate all header changes into TSO function Alexander Duyck
2016-01-27 16:14 ` Bowers, AndrewX
2016-01-25 5:16 ` [Intel-wired-lan] [next PATCH v3 05/15] i40e/i40evf: Replace header pointers with unions of pointers in Tx checksum path Alexander Duyck
2016-01-27 16:27 ` Bowers, AndrewX
2016-01-25 5:16 ` [Intel-wired-lan] [next PATCH v3 06/15] i40e/i40evf: Add support for IPv4 encapsulated in IPv6 Alexander Duyck
2016-01-27 18:04 ` Bowers, AndrewX
2016-01-25 5:16 ` [Intel-wired-lan] [next PATCH v3 07/15] i40e/i40evf: Handle IPv6 extension headers in checksum offload Alexander Duyck
2016-01-27 18:05 ` Bowers, AndrewX
2016-01-25 5:17 ` [Intel-wired-lan] [next PATCH v3 08/15] i40e/i40evf: Do not write to descriptor unless we complete Alexander Duyck
2016-01-27 18:07 ` Bowers, AndrewX
2016-01-25 5:17 ` [Intel-wired-lan] [next PATCH v3 09/15] i40e/i40evf: Add exception handling for Tx checksum Alexander Duyck
2016-01-27 18:08 ` Bowers, AndrewX
2016-01-25 5:17 ` [Intel-wired-lan] [next PATCH v3 10/15] i40e/i40evf: Clean-up Rx packet checksum handling Alexander Duyck
2016-01-27 18:09 ` Bowers, AndrewX
2016-01-25 5:17 ` [Intel-wired-lan] [next PATCH v3 11/15] i40e/i40evf: Enable support for SKB_GSO_UDP_TUNNEL_CSUM Alexander Duyck
2016-01-27 18:17 ` Bowers, AndrewX
2016-02-02 22:49 ` Jesse Brandeburg
2016-02-02 23:10 ` Jesse Brandeburg
2016-02-02 23:18 ` Jesse Brandeburg
2016-02-03 0:06 ` Alexander Duyck
2016-01-25 5:17 ` [Intel-wired-lan] [next PATCH v3 12/15] i40e: Fix ATR in relation to tunnels Alexander Duyck
2016-01-25 19:27 ` Patil, Kiran
2016-01-25 22:21 ` Alexander Duyck
2016-01-26 0:16 ` Patil, Kiran
2016-01-27 18:18 ` Bowers, AndrewX
2016-01-25 5:17 ` [Intel-wired-lan] [next PATCH v3 13/15] i40e: Do not drop support for IPv6 VXLAN or GENEVE tunnels Alexander Duyck
2016-01-27 18:26 ` Bowers, AndrewX
2016-01-25 5:17 ` [Intel-wired-lan] [next PATCH v3 14/15] i40e: Update feature flags to reflect newly enabled features Alexander Duyck
2016-01-27 18:44 ` Bowers, AndrewX
2016-01-25 5:17 ` [Intel-wired-lan] [next PATCH v3 15/15] i40evf: " Alexander Duyck
2016-01-25 19:43 ` Singhai, Anjali
2016-01-27 18:45 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125050602.12004.38884.stgit@localhost.localdomain \
--to=aduyck@mirantis.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.