From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Date: Mon, 25 Jan 2016 11:14:23 +0000 Subject: Re: [PATCH] drivers/media: vsp1_video: fix compile error Message-Id: <20160125091423.386ae714@recife.lan> List-Id: References: <1452816583-11036-1-git-send-email-anders.roxell@linaro.org> <1991984.ioj231CKOU@avalon> In-Reply-To: <1991984.ioj231CKOU@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Pinchart Cc: Anders Roxell , linux-media@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Em Mon, 25 Jan 2016 00:15:28 +0200 Laurent Pinchart escreveu: > Hi Anders, > > Thank you for the patch. > > On Friday 15 January 2016 01:09:43 Anders Roxell wrote: > > This was found with the -RT patch enabled, but the fix should apply to > > non-RT also. > > > > Compilation error without this fix: > > ../drivers/media/platform/vsp1/vsp1_video.c: In function > > 'vsp1_pipeline_stopped': > > ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected > > expression before 'do' > > spin_unlock_irqrestore(&pipe->irqlock, flags); > > ^ > > > > Signed-off-by: Anders Roxell > > Reviewed-by: Laurent Pinchart > > and applied to my tree. Better to apply this to the fixes branch and send it together with the next set of patches upstream. > > > --- > > drivers/media/platform/vsp1/vsp1_video.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/vsp1/vsp1_video.c > > b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644 > > --- a/drivers/media/platform/vsp1/vsp1_video.c > > +++ b/drivers/media/platform/vsp1/vsp1_video.c > > @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline > > *pipe) bool stopped; > > > > spin_lock_irqsave(&pipe->irqlock, flags); > > - stopped = pipe->state = VSP1_PIPELINE_STOPPED, > > + stopped = pipe->state = VSP1_PIPELINE_STOPPED; > > spin_unlock_irqrestore(&pipe->irqlock, flags); > > > > return stopped; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH] drivers/media: vsp1_video: fix compile error Date: Mon, 25 Jan 2016 09:14:23 -0200 Message-ID: <20160125091423.386ae714@recife.lan> References: <1452816583-11036-1-git-send-email-anders.roxell@linaro.org> <1991984.ioj231CKOU@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Anders Roxell , linux-media@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org To: Laurent Pinchart Return-path: In-Reply-To: <1991984.ioj231CKOU@avalon> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-rt-users.vger.kernel.org Em Mon, 25 Jan 2016 00:15:28 +0200 Laurent Pinchart escreveu: > Hi Anders, > > Thank you for the patch. > > On Friday 15 January 2016 01:09:43 Anders Roxell wrote: > > This was found with the -RT patch enabled, but the fix should apply to > > non-RT also. > > > > Compilation error without this fix: > > ../drivers/media/platform/vsp1/vsp1_video.c: In function > > 'vsp1_pipeline_stopped': > > ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected > > expression before 'do' > > spin_unlock_irqrestore(&pipe->irqlock, flags); > > ^ > > > > Signed-off-by: Anders Roxell > > Reviewed-by: Laurent Pinchart > > and applied to my tree. Better to apply this to the fixes branch and send it together with the next set of patches upstream. > > > --- > > drivers/media/platform/vsp1/vsp1_video.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/vsp1/vsp1_video.c > > b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644 > > --- a/drivers/media/platform/vsp1/vsp1_video.c > > +++ b/drivers/media/platform/vsp1/vsp1_video.c > > @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline > > *pipe) bool stopped; > > > > spin_lock_irqsave(&pipe->irqlock, flags); > > - stopped = pipe->state == VSP1_PIPELINE_STOPPED, > > + stopped = pipe->state == VSP1_PIPELINE_STOPPED; > > spin_unlock_irqrestore(&pipe->irqlock, flags); > > > > return stopped; >