From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] test.sh and ROD redirection
Date: Mon, 25 Jan 2016 14:45:21 +0100 [thread overview]
Message-ID: <20160125134520.GE30655@rei.lan> (raw)
In-Reply-To: <20160125111654.GA30655@rei.lan>
Hi!
> Another option would be inventing our special syntax for redirecting for
> ROD. Use for example % and threat it like > i.e. split $@ on % and
> redirect the output to whatever is found after % which shouldn't be
> much more complicated than separating last parameter from $@...
What about this one:
diff --git a/testcases/lib/test.sh b/testcases/lib/test.sh
index 074be74..ef2af14 100644
--- a/testcases/lib/test.sh
+++ b/testcases/lib/test.sh
@@ -214,7 +214,29 @@ ROD_SILENT()
ROD()
{
- $@
+ local cmd
+ local arg
+ local file
+ local flag
+
+ for arg; do
+ if [ "$arg" == ">" ]; then
+ flag=1
+ continue
+ fi
+
+ if [ -n "$flag" ]; then
+ break
+ fi
+ cmd="$cmd $arg"
+ done
+
+ if [ -n "$flag" ]; then
+ $cmd > $arg
+ else
+ $@
+ fi
+
if [ $? -ne 0 ]; then
tst_brkm TBROK "$@ failed"
fi
It's called as: 'ROD echo a \> b', the reason for choosing \> is that
the error message will contain '>' instead of some strange char as %.
I.e. doing 'ROD echo a \> /proc/cpuinfo' yields:
test.sh: line 235: /proc/cpuinfo: Permission denied
foo 1 TBROK : echo b > /proc/cpuinfo failed
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-01-25 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 13:51 [LTP] test.sh and ROD redirection Cyril Hrubis
2016-01-22 9:15 ` Alexey Kodanev
2016-01-25 11:16 ` Cyril Hrubis
2016-01-25 13:45 ` Cyril Hrubis [this message]
2016-01-25 16:26 ` Alexey Kodanev
2016-01-25 16:41 ` Cyril Hrubis
2016-01-25 17:18 ` Cyril Hrubis
2016-01-25 17:51 ` Alexey Kodanev
2016-01-25 18:07 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125134520.GE30655@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.