Re: [PATCH 0/9] Support blending modes of display planes

From: Daniel Vetter <daniel@ffwll.ch>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/9] Support blending modes of display planes
Date: Mon, 25 Jan 2016 17:19:43 +0100	[thread overview]
Message-ID: <20160125161943.GS11240@phenom.ffwll.local> (raw)
In-Reply-To: <20160122003140.GF13311@intel.com>

On Thu, Jan 21, 2016 at 04:31:40PM -0800, Matt Roper wrote:
> On Mon, Jan 18, 2016 at 08:45:34PM +0530, Vandita Kulkarni wrote:
> > From: vandita kulkarni <vandita.kulkarni@intel.com>
> > 
> > The below patches support plane and pixel blending
> > by adding two properties blend_func and blend_color.
> > As per Damien's initial patches, this design based on 
> > OpenGL's blend equations is suggested by Ville.
> > All the below patches are tested on BXT android platform.
> > 
> > The initial kernel patches from damien can be found at
> > https://github.com/dlespiau/linux/commits/20150708-alpha-blending
> > Damien Lespiau (5):
> >   drm: Introduce the blend-func property
> >   drm/i915/skl: Add blend_func to SKL/BXT sprite planes
> >   drm: Introduce DRM_MODE_COLOR()
> >   drm: Add an blend_color property
> >   drm/i915/skl: Add support for blending modes
> > 
> > vandita kulkarni (4):
> >   drm/i915/skl: Drop alpha in non ARGB formats
> >   drm/i915: Support blend func on primary
> >   drm/i915/skl: Support blend color on primary
> >   drm/i915/skl: Separate out disable plane alpha
> 
> This series looks pretty good; I've given some feedback on a few of the
> patches, but it's all pretty minor.  And some of the feedback I gave
> wound up being addressed in later patches in the series anyway; I think
> you can probably squash patches 6-9 into the earlier patches to simplify
> a bit.
> 
> One of the requirements to merge new features upstream is to have an
> opensource userspace that makes use of it.  It sounds like you're doing
> this work for Android purposes, so is the plan to add support for these
> properties to hwcomposer?

Note that I'm still in the process of getting approval for contributing to
the new drm_hwcomposer. It seems this will take a while unfortunately :(
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx